-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniswap: summary of initialization of configuration #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the semantics itself looks fine, but I'd like us to tweak the test suite so that it's a little less messy to add the additional parameter.
bin/krun-sol
Outdated
shift; shift | ||
krun -d "$(dirname "$0")/../solidity-kompiled" "$contract" -cTXN="$txn" -pTXN="$(dirname "$0")/kparse-txn" --no-expand-macros "$@" | ||
isuniswap="$3" | ||
shift; shift; shift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make krun-sol optionally take a third argument rather than making it required, and let's make the tests in test/regression automatically not pass that optional value, rather than adding a bunch of additional files to the test suite and breaking the interface of krun-sol
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. krun-sol has now an optional 3rd argument, that defaults to false. The tests in regression do not pass this argument.
9dcffe4
to
41f6450
Compare
This PR includes the following changes:
The mechanism used to apply the summarized rule is matching the contents of the new cell, to apply either the summarized rule or the initial rewrite rule
, because for some reason I cannot figure out the priority does not help here.