-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniswap modifications to enable summarization #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine but I'd like us to get regression testing working. So please either set up a test harness for the test/examples directory (preferred), or just put this in test/regression.
I set up the infrastructure for testing in the examples directory. |
This PR creates a copy of the UniswapV2Swap test, and makes the following changes, mostly related to names:
The test has been locally tested to rewrite to .K for the provided input.