Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

Independently sized thumbnails #77

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Ligraph
Copy link

@Ligraph Ligraph commented Dec 1, 2016

Made it so that thumbnails can be resized independently. Sizes save and load, and work with per client layouts.

I had to add packages to the gitignore so the dependent packages wouldn't get uploaded, not sure if that will break anything (I'm using VS).

@Phrynohyas
Copy link
Owner

Cool
I'll take a deeper look over the weekend

A couple of notes, if you don't mind

  1. The everalsting battle of spaces vs tabs (you use spaces while the rest of the project uses tabs)
  2. Please add a [JsonProperty("old name here")] attribute to the renamed property in the config class to retain config files compatibility

No need to change anything in the pull request, I'll fix them during the code review

Thanks again

This opens the road to 3.0.0 release with the major 'not only EVE client previews' feature

@Ligraph
Copy link
Author

Ligraph commented Dec 1, 2016

Is there a way to change Visual studio to use tabs? I had no idea it was doing that.

@Phrynohyas
Copy link
Owner

The setting is under

Tools -> Options -> Text Editor -> C# -> Tabs

@Ligraph
Copy link
Author

Ligraph commented Dec 1, 2016

Do you think I should take out the default thumbnail size option and ui? Seems like its not really needed.

@Phrynohyas
Copy link
Owner

What really would be better is to keep the UI + add a checkbox like 'Sync size' (need better text here) or something
The ideal UX would be:
When the checkbox is set and size value is changed then all thumbnails are resized to this value
When the checkbox i NOT set and size value is changed then only thumbnails with non-custom sizes are resized

So one can resize come thumbnails as he want and still can manage size of all thumbnails at once

If you'll work on this then please confirm otherwise I'll try to implement this over the weekend

@Ligraph
Copy link
Author

Ligraph commented Dec 2, 2016

I'll see what I can do. Right now I'm saving all thumbnail sizes, so I need to change that. I think it will work better this way anyways.

@Ligraph
Copy link
Author

Ligraph commented Dec 2, 2016

So the way I'm doing it I either need to make RefreshThumbnails public or iterate through thumbnails and change the size of any that aren't custom sized. I'm thinking the first is easier, will it cause any issues with the rest of the app?

EDIT: I can just use Activate.

@Phrynohyas
Copy link
Owner

make RefreshThumbnails public
That would mean an abstraction leak as this method is not meant to be public.

@Ligraph
Copy link
Author

Ligraph commented Dec 2, 2016

I have what you said earlier implemented, but I want to create a way for someone to have most of their thumbnails synced to the default size with one or two resized. The only way I can think of atm would be a checked list but that feels like unnecessary clutter, so I'm going to think on it.

@Ligraph
Copy link
Author

Ligraph commented Dec 2, 2016

I'm trying to make the thumbnails non-resizeable when sync sizes is checked, but no mater what I do I can't get it to work. I'm setting BorderStyle to FixedToolWindow, is there something else I need to change?

EDIT: made it work.

@Ligraph
Copy link
Author

Ligraph commented Dec 3, 2016

For some reason FixedToolWindow appears to have a smaller top border than SizeableToolWindow, I'm not sure why or how to fix it.

A related problem: Because of this size change, when sync is unchecked, a resize event is called because the size of the top bar changes, and since sync is off it updates the size of the thumbnail to that (incorrect) size. I think this is what causes it, not 100% sure.

EDIT: The problem is with the frame, because it works fine with disabled frames. Highlighting works fine though, so idk.

EDIT 2: Fixed.

@Phrynohyas
Copy link
Owner

@Ligraph: Can this feature be considered as 'Completed'?

@Ligraph
Copy link
Author

Ligraph commented Dec 3, 2016

Yeah.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants