Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor]fixed bug that event 601 & 602 don't work properly in single player maps #1425

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

handama
Copy link
Contributor

@handama handama commented Nov 16, 2024

Trigger event 601 & 602 don't work properly in single player maps, while 604 & 605 do. The only distinction between them is what I've changed. You can test the result with this map:
all01umd.zip

By the way, phobos's new events and actions use FindByIndex/Array->GetItem instead of FindByCountryIndex, which leads to inconsistency with the vanilla events and actions, for they use country index instead of house index. In single player map with whole new houses (like official RA2 campaign, they use BadGuy1, GoodGuy1 etc.), it begins with 14 by country index, but 0 by house index. This may make map editing and FA2 adaptation more complicated, so I want to know your opinions.

If you want to restore the vanilla habit, just modify in this way
B17A4FF7777CB422DB89F0CE84E77E66

@github-actions github-actions bot added the Minor Documentation is not required label Nov 16, 2024
Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants