-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the Building Actions #1335
base: develop
Are you sure you want to change the base?
Conversation
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Building placing and deploying logic enhancement
In [Phobos]
DrawAdjacentBoundary=false ; boolean
ShowBuildingStatistics=false ; boolean In [General]
CheckUnitBaseNormal=false ; boolean
ExpandBuildingPlace=false ; boolean
[AudioVisual]
PlacementGrid.Expand=false ; boolean
PlacementGrid.LandFrames=1,0,0 ; integer, zero-based frame index - have technos, near boundary, is normal
PlacementGrid.WaterFrames=1,0,0 ; integer, zero-based frame index - have technos, near boundary, is normal
Cameo.AlwaysExist=false ; boolean
Cameo.OverlayShapes=pips.shp ; filename - including the .shp extension
Cameo.OverlayFrames=-1,-1,-1 ; integer - owned this building, grey and have its prerequisite, grey but have no prerequisite
Cameo.OverlayPalette=palette.pal ; filename - including the .pal extension
[SOMEBUILDING] ; BuildingType
AutoUpgrade=false ; boolean
LimboBuild=false ; boolean
LimboBuildID=-1 ; boolean
[SOMETECHNO] ; TechnoType
CanBeBuiltOn=false ; boolean
Cameo.AlwaysExist= ; boolean
Cameo.AuxTechnos= ; List of TechnoTypes
Cameo.NegTechnos= ; List of TechnoTypes
UIDescription.Unbuildable= ; CSF entry key
[SOMEUNIT] ; UnitType
UnitBaseNormal=false ; boolean
UnitBaseForAllyBuilding=false ; boolean In [SOMETECHNO] ; TechnoType
GreyCameoPCX= ; PCX filename - including the .pcx extension |
this should be merged asap |
If I may suggest some more appropriate English for these tags: And cannot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure about its logical correctness yet, more reviewing is definitely needed
also perhaps it should be separated to 4 different pull request for baseNormal, cameo display, building grid display and units auto moving/killed when building
If the features are not very intertwined and it's not hard to do a split would be preferable. I understand that we're over our review capacity at the moment though and because of that maybe it's not necessary at least yet. |
Get the idea. The placing grids and units base normal are hard to split, but I think it can still be divided into three parts, although it will take me some time. So later I will make modifications to the review that was just submitted, then do a split when I have time. |
I will update the docs soon and these GIFs will show you the main function.