remove cmake files

Phobos-developers · Oct 5, 2023 · 83da5f4 · 83da5f4
1 parent 2ba6192
commit 83da5f4
Show file tree

Hide file tree

Showing 7 changed files with 87 additions and 179 deletions.
diff --git a/.clang-format b/.clang-format
@@ -1,21 +1,39 @@
 ---
 # See all possible options and defaults with:
-# clang-format --style=llvm --dump-config
-BasedOnStyle: LLVM
+# clang-format --style=Microsoft --dump-config
+BasedOnStyle: Microsoft
 Language: Cpp
-# Standard: Cpp20
+Standard: c++20
 AccessModifierOffset: -4
-AllowShortLambdasOnASingleLine: true
 AlwaysBreakTemplateDeclarations: Yes
 BinPackArguments: false
 BinPackParameters: false
 BreakBeforeBinaryOperators: All
 BreakConstructorInitializers: BeforeColon
-ColumnLimit: 99
+ColumnLimit: 0
 CommentPragmas: 'NOLINT:.*|^ IWYU pragma:'
 IncludeBlocks: Regroup
 IndentCaseLabels: true
 IndentPPDirectives: AfterHash
-IndentWidth: 4
+# IndentWidth: 4
 SpaceAfterCStyleCast: true
 TabWidth: 4
+AlignAfterOpenBracket: Align
+AlignConsecutiveAssignments: true
+AlignConsecutiveDeclarations: true
+AllowAllParametersOfDeclarationOnNextLine: false
+AllowShortFunctionsOnASingleLine: None
+AllowShortIfStatementsOnASingleLine: true
+AllowShortLoopsOnASingleLine: true
+AllowShortLambdasOnASingleLine: Inline
+AlwaysBreakAfterReturnType: None
+AlwaysBreakBeforeMultilineStrings: true
+BreakBeforeBraces: Allman
+DerivePointerAlignment: false
+KeepEmptyLinesAtTheStartOfBlocks: false
+NamespaceIndentation: None
+PointerAlignment: Left
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeParens: ControlStatements
+SpaceInEmptyParentheses: false
+SpacesBeforeTrailingComments: 1
diff --git a/.clang-tidy b/.clang-tidy
@@ -20,7 +20,7 @@ Checks: |
   misc-unused-parameters,
   modernize-avoid-bind,
   modernize-loop-convert,
-  modernize-make-shared,
+  modernize-make-unique,
   modernize-redundant-void-arg,
   modernize-replace-auto-ptr,
   modernize-replace-disallow-copy-and-assign-macro,
@@ -34,7 +34,6 @@ Checks: |
   modernize-use-equals-delete,
   modernize-use-noexcept,
   modernize-use-nullptr,
-  modernize-use-override,
   modernize-use-using,
   readability-avoid-const-params-in-decls,
   readability-braces-around-statements,

diff --git a/.cmake-format.yaml b/.cmake-format.yaml
diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml
@@ -0,0 +1,27 @@
+name: clang-format Check
+on:
+  pull_request:
+  push:
+    branches:
+      - clang-format
+      # - develop
+jobs:
+  formatting-check:
+    name: Formatting Check
+    runs-on: windows-latest
+    strategy:
+      matrix:
+        path:
+          - check: 'src'
+            exclude: '(Dummy|Sample|Coroutine)'
+          # - check: 'docs'
+            # exclude: ''
+    steps:
+    - uses: actions/checkout@v3
+    - name: Run clang-format style check for C/C++/Protobuf programs.
+      uses: jidicula/clang-format-action@v4.11.0
+      with:
+        clang-format-version: '13'
+        check-path: ${{ matrix.path['check'] }}
+        exclude-regex: ${{ matrix.path['exclude'] }}
+        fallback-style: 'Mozilla'
diff --git a/.github/workflows/clang-tidy-check.yml b/.github/workflows/clang-tidy-check.yml
@@ -0,0 +1,29 @@
+name: clang-tidy-review
+
+# You can be more specific, but it currently only works on pull requests
+on:
+  pull_request:
+  push:
+    branches:
+      - clang-format
+      # - develop
+
+jobs:
+  build:
+    runs-on: windows-latest
+
+    steps:
+    - uses: actions/checkout@v3
+
+    # Optionally generate compile_commands.json
+
+    - uses: ZedThree/clang-tidy-review@v0.12.0
+      id: review
+
+    # Uploads an artefact containing clang_fixes.json
+    - uses: ZedThree/clang-tidy-review/upload@v0.12.0
+      id: upload-review
+
+    # If there are any comments, fail the check
+    - if: steps.review.outputs.total_comments > 0
+      run: exit 1
diff --git a/CMakeLists.txt b/CMakeLists.txt
diff --git a/Phobos.vcxproj b/Phobos.vcxproj
@@ -309,20 +309,26 @@
     <LinkIncremental>false</LinkIncremental>
     <OutDir>$(Configuration)\</OutDir>
     <IntDir>$(Configuration)\IntDir\</IntDir>
+    <EnableClangTidyCodeAnalysis>true</EnableClangTidyCodeAnalysis>
+    <ClangTidyChecks>-clang-diagnostic-pragma-once-outside-header</ClangTidyChecks>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='DevBuild|Win32'">
     <GenerateManifest>false</GenerateManifest>
     <IncludePath>$(SolutionDir)src\;$(SolutionDir)src\ExtraHeaders;$(SolutionDir)yrpp;$(SolutionDir)lib;$(VC_IncludePath)</IncludePath>
     <LinkIncremental>false</LinkIncremental>
     <OutDir>$(Configuration)\</OutDir>
     <IntDir>$(Configuration)\IntDir\</IntDir>
+    <EnableClangTidyCodeAnalysis>true</EnableClangTidyCodeAnalysis>
+    <ClangTidyChecks>-clang-diagnostic-pragma-once-outside-header</ClangTidyChecks>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <GenerateManifest>false</GenerateManifest>
     <IncludePath>$(SolutionDir)src\;$(SolutionDir)src\ExtraHeaders;$(SolutionDir)yrpp;$(SolutionDir)lib;$(VC_IncludePath)</IncludePath>
     <LinkIncremental>false</LinkIncremental>
     <OutDir>$(Configuration)\</OutDir>
     <IntDir>$(Configuration)\IntDir\</IntDir>
+    <EnableClangTidyCodeAnalysis>true</EnableClangTidyCodeAnalysis>
+    <ClangTidyChecks>-clang-diagnostic-pragma-once-outside-header</ClangTidyChecks>
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
     <ClCompile>