Fix demos to use jax that require grads #1226
Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
[sc-73935] * Remove deprecated code from demos. * Update various `from pennylane import numpy as np` to `import numpy as np`.
**Summary:** Fixes a merge conflict between `master` and `dev` introduced by #1232 (due to divergent `dateOfLastModification`). To reproduce this PR: 1. Run `git checkout dev`. 2. Run `git checkout -b merge-master-into-dev`. 3. Run `git merge master`. 4. Accept all incoming changes for merge conflicts on `dateOfLastModification`. **Relevant GHA Workflow Runs:** * https://github.com/PennyLaneAI/qml/actions/runs/11241666164 * https://github.com/PennyLaneAI/qml/actions/runs/11253088983 --------- Co-authored-by: David Wierichs <davidwierichs@gmail.com> Co-authored-by: Korbinian Kottmann <43949391+Qottmann@users.noreply.github.com> Co-authored-by: Ivana Kurečić <ivana@xanadu.ai>
- Branched off dev - Merged Master in via `--allow-unrelated-histories` Co-authored-by: Jack Brown <jack.brown486@gmail.com>
austingmhuang
changed the title
| # In this example, we use the ``default.qubit`` simulator: | ||
| num_wires = 6 | ||
| dev = qml.device("lightning.qubit", wires=num_wires) | ||
| dev = qml.device("default.qubit", wires=num_wires) |
There was a problem hiding this comment.
For some reason lightning.qubit doesn't work with JAX here. Not sure why but I had to change to using default to get it working.
Steps used for this merge: 1. Create new branch from `dev` 2. Merge `master` into that branch 3. Open PR --------- Co-authored-by: Jack Brown <jack.brown486@gmail.com> Co-authored-by: Ivana Kurečić <ivana@xanadu.ai>
There was a problem hiding this comment.
Thanks @austingmhuang. before doing a full review, could you please make sure that this PR targets dev instead of master? Also, if there is any demo that does not require features in dev, their upgrade should be done in this PR.
| from jax import numpy as jnp | ||
| import jax |
There was a problem hiding this comment.
Let's just use vanilla numpy in this demo.
| from pennylane import qchem | ||
| from pennylane import numpy as np | ||
| from jax import numpy as jnp | ||
|
|
||
| symbols = ['H', 'H'] | ||
| geometry = np.array([[0.0, 0.0, -0.69434785], | ||
| [0.0, 0.0, 0.69434785]], requires_grad = False) | ||
| geometry = jnp.array([[0.0, 0.0, -0.69434785], | ||
| [0.0, 0.0, 0.69434785]]) |
There was a problem hiding this comment.
This demo is already updated in another PR, correct?
There was a problem hiding this comment.
No, it's not updated in that PR. Well that PR had a one line change in this demo by accident.
There was a problem hiding this comment.
This demo doesn't work without the requires_grad changes because it calls fermionic_hamiltonian directly
| from pennylane import numpy as np | ||
| import numpy as np |
There was a problem hiding this comment.
Can we update this demo in this PR as well?
There was a problem hiding this comment.
No, it cannot be done. This demo calls electronic_integrals() directly, which checks for requires_grad, leading to an error.
Steps used: * Checkout new branch from `dev` * Merge `master` using `git merge master` * Publish branch and open PR --------- Co-authored-by: Jack Brown <jack.brown486@gmail.com> Co-authored-by: Ivana Kurečić <ivana@xanadu.ai> Co-authored-by: bellekaplan <167111433+bellekaplan@users.noreply.github.com>
|
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
Doesn't build due to the fact that this PR is not yet merged. JSON files need to be updated as well.
Summary:
Fixes remaining demos that checked for requires_grad. Won't build for now due to missing a fix in this PR
[sc-69776] [sc-69778]