Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash #58

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Trailing slash #58

merged 2 commits into from
Dec 2, 2024

Conversation

rw2
Copy link
Collaborator

@rw2 rw2 commented Nov 21, 2024

fixed the requirement to have a trailing slash

@rw2 rw2 linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this solves the trailing / issue for me.

@jhiemstrawisc
Copy link
Member

@rw2, before we merge can you clean up the commit history a bit to describe each step of the process?

@jhiemstrawisc jhiemstrawisc merged commit fe48042 into PelicanPlatform:main Dec 2, 2024
3 checks passed
@jhiemstrawisc jhiemstrawisc added bug Something isn't working S3 Specific to the S3 plugin labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working S3 Specific to the S3 plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants