Import parameters.json into website #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CannonLock
force-pushed
the
issue-971
branch
9 times, most recently
from
cf9067c
to
5033ce5
Compare
haoming29
suggested changes
Mar 25, 2024
Adds check that go generate has been run on the latest commit Moves make web-build into goreleaser before which will make how we build dev binaries more similar to how we build production binaries Rewrites the dockerfile moving the web build into the gorelease section Doesn't needlessly update parameters.json on go generate ./..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify Build Process
Adds check that go generate has been run on the latest commit
Moves make web-build into goreleaser before which will make how we build dev binaries more similar to how we build production binaries
Rewrites the dockerfile moving the web build into the gorelease section
Doesn't needlessly update parameters.json on go generate ./..
Closes #971