Write config UI #909
Merged
Write config UI #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CannonLock
commented
Mar 7, 2024
•
CannonLock
commented
- Adds ability to edit the config
- Type checking where possible
This was
linked to
issues
Mar 7, 2024
haoming29
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Two minor changes requested and are non-blocking so feel free to tackle them or leave them for now but otherwise looks pretty nice to me!
I'm thinking it would be very nice if we could add "Cancel" button next to save, so that users mistakenly changing a value have the chance to ignore the change. Could be just a button to refresh the page if that's easier to implement.
As we talked in person, currently if a user changes a value and re-do the change, frontend will still send that change back to backend, which won't be a big issue now but we can fix them in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.