first working draft

Makefile

@@ -1,21 +1,10 @@
 install:
 	## check if vars are set
-	source ./check_vars.sh GOPATH
-	## check for sudo privileges
-	source ./check_sudo.sh
+	bash ./check_vars.sh GOPATH
 	## run go install
 	go install ./...
 	## create system-wide symlink to executables
-	source ./create_symlinks.sh motion-poll set-preset goto-preset set-time
+	bash ./create_symlinks.sh motion-poll set-preset goto-preset set-time
 	## create config folder
-	echo "Path for configuration folder [~/.config/onvif-cam-poll]"
-	read path
-	if [ -z "$path" ]
-	then path="~/.config/onvif-cam-poll"
-	mkdir -p $path
-	## create service templates
-		cp ./services/* $path/.
-        ## overwrite service files - environment file, user, group, execstart
-        ## copy service files to system service folder
-        ## run systemctl daemon-reload
+	bash ./create_service_templates.sh
 

check_vars.sh

@@ -1,11 +1,11 @@
-function check_var() {
+#!/bin/bash
+function check_var {
   declare -n var_ref=$1
-  declare -p "$var_ref" &>/dev/null
   declared=$?
-  if ["$declared" != 0 ]
+  if [ "$declared" != 0 ]
   then
     echo "$var_ref must be set! Exiting!"
-    exit
+    exit 1
   fi
 }
 

create_service_templates.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+read -r -p "Path for configuration folder [~/.config/onvif-cam-poll]" $CONFIG_PATH
+export CONFIG_PATH=${config_path:-~/.config/onvif-cam-poll}
+echo "$CONFIG_PATH"
+mkdir --p "$CONFIG_PATH"
+export CONFIG_PATH
+## create service templates
+cp ./services/* "$CONFIG_PATH"/.
+envsubst < "$CONFIG_PATH"/motion@.service > "$CONFIG_PATH"/motion@.service.temp && mv "$CONFIG_PATH"/motion@.service.temp "$CONFIG_PATH"/motion@.service
+envsubst < "$CONFIG_PATH"/time@.service > "$CONFIG_PATH"/time@.service.temp && mv "$CONFIG_PATH"/time@.service.temp "$CONFIG_PATH"/time@.service
+sudo cp "$CONFIG_PATH"/*.service /lib/systemd/system/.
+sudo systemctl daemon-reload
+echo "To track a new camera create an .env file for it in $CONFIG_PATH"
+echo "Fill in all the variables that are listed in the example.env file"
+echo "Afterwards, run systemctl start motion@camera_envfile_name"
+echo "Don't forget to enable the service if you want it to run after a restart"

create_symlinks.sh

@@ -1,5 +1,6 @@
 function create_symlink() {
-  ln -s "$GOPATH/$1" "/usr/bin/$1"
+  sudo rm "/usr/bin/$1"
+  sudo ln -s "$GOPATH/$1" "/usr/bin/$1"
 }
 
 for var in "$@"

motion@.service

@@ -0,0 +1,16 @@
+[Unit]
+DefaultDependencies=no
+After=network.target
+
+[Service]
+Type=simple
+EnvironmentFile=/home/isaric/.config/onvif-cam-poll/%i.env
+Restart=always
+RestartSec=3
+User=isaric
+Group=isaric
+ExecStart=/bin/bash /home/isaric/.config/onvif-cam-poll/motion.sh
+TimeoutStartSec=0
+
+[Install]
+WantedBy=default.target

onfig_path/example.env

@@ -0,0 +1,6 @@
+CAMERA_ADDRESS=bla.bla.bla:8899
+CAMERA_USER=admin
+CAMERA_PASSWORD=xxxxxx
+CAMERA_NAME=garage
+SLACK_BOT_TOKEN=xoxb-xxxxxx-xxxxxx-xxxxxx
+SLACK_CHANNEL_ID=xxxxxx

onfig_path/motion.sh

@@ -0,0 +1 @@
+motion-poll -a ${CAMERA_ADDRESS} -u ${CAMERA_USER} -p ${CAMERA_PASSWORD} -n ${CAMERA_NAME} -s ${SLACK_WEBHOOK} -t 30 -b ${SLACK_BOT_TOKEN} -c ${SLACK_CHANNEL_ID}

onfig_path/motion@.service

@@ -0,0 +1,16 @@
+[Unit]
+DefaultDependencies=no
+After=network.target
+
+[Service]
+Type=simple
+EnvironmentFile=$path/%i.env
+Restart=always
+RestartSec=3
+User=$SUDO_USER
+Group=$SUDO_USER
+ExecStart=/bin/bash $path/motion.sh
+TimeoutStartSec=0
+
+[Install]
+WantedBy=default.target

onfig_path/time.sh

@@ -0,0 +1 @@
+set-time -a ${CAMERA_ADDRESS} -u admin -p ${CAMERA_PASSWORD}

onfig_path/time@.service

@@ -0,0 +1,16 @@
+[Unit]
+DefaultDependencies=no
+After=network.target
+
+[Service]
+Type=simple
+EnvironmentFile=$path/%i.env
+Restart=always
+RestartSec=3
+User=$SUDO_USER
+Group=$SUDO_USER
+ExecStart=/bin/bash $path/time.sh
+TimeoutStartSec=0
+
+[Install]
+WantedBy=default.target

services/goto-preset@.service

@@ -0,0 +1,16 @@
+[Unit]
+DefaultDependencies=no
+After=network.target
+
+[Service]
+Type=simple
+EnvironmentFile=${CONFIG_PATH}/%i.env
+Restart=always
+RestartSec=3
+User=${USER}
+Group=${USER}
+ExecStart=/bin/bash ${CONFIG_PATH}/goto.sh
+TimeoutStartSec=0
+
+[Install]
+WantedBy=default.target

services/goto.sh

@@ -0,0 +1 @@
+goto-preset -a ${CAMERA_ADDRESS} -u ${CAMERA_USER} -p ${CAMERA_PASSWORD} -t 30 -l 001

services/motion.sh

@@ -1 +1 @@
-/path/to/motion-poll -a ${CAMERA_ADDRESS} -u ${CAMERA_USER} -p ${CAMERA_PASSWORD} -n ${CAMERA_NAME} -s ${SLACK_WEBHOOK} -t 30 -b ${SLACK_BOT_TOKEN} -c ${SLACK_CHANNEL_ID}
+motion-poll -a ${CAMERA_ADDRESS} -u ${CAMERA_USER} -p ${CAMERA_PASSWORD} -n ${CAMERA_NAME} -s ${SLACK_WEBHOOK} -t 30 -b ${SLACK_BOT_TOKEN} -c ${SLACK_CHANNEL_ID}

services/motion@.service

@@ -4,12 +4,12 @@ After=network.target
 
 [Service]
 Type=simple
-EnvironmentFile=/home/your-user/motion-poll-services/%i.env
+EnvironmentFile=${CONFIG_PATH}/%i.env
 Restart=always
 RestartSec=3
-User=isaric
-Group=isaric
-ExecStart=/bin/bash /home/your-user/motion-poll-services/motion.sh
+User=${USER}
+Group=${USER}
+ExecStart=/bin/bash ${CONFIG_PATH}/motion.sh
 TimeoutStartSec=0
 
 [Install]

services/set-preset.sh

@@ -0,0 +1 @@
+set-preset -a ${CAMERA_ADDRESS} -u ${CAMERA_USER} -p ${CAMERA_PASSWORD} -l 001

services/set-preset@.service

@@ -0,0 +1,16 @@
+[Unit]
+DefaultDependencies=no
+After=network.target
+
+[Service]
+Type=simple
+EnvironmentFile=${CONFIG_PATH}/%i.env
+Restart=always
+RestartSec=3
+User=${USER}
+Group=${USER}
+ExecStart=/bin/bash ${CONFIG_PATH}/set-preset.sh
+TimeoutStartSec=0
+
+[Install]
+WantedBy=default.target

services/time.sh

@@ -1 +1 @@
-/path/to/set-time -a ${CAMERA_ADDRESS} -u admin -p ${CAMERA_PASSWORD}
+set-time -a ${CAMERA_ADDRESS} -u admin -p ${CAMERA_PASSWORD}

services/time@.service

@@ -4,12 +4,12 @@ After=network.target
 
 [Service]
 Type=simple
-EnvironmentFile=/home/your-user/motion-poll-services/%i.env
+EnvironmentFile=${CONFIG_PATH}/%i.env
 Restart=always
 RestartSec=3
-User=isaric
-Group=isaric
-ExecStart=/bin/bash /home/your-user/motion-poll-services/time.sh
+User=${USER}
+Group={$USER}
+ExecStart=/bin/bash ${CONFIG_PATH}/time.sh
 TimeoutStartSec=0
 
 [Install]

time@.service

@@ -0,0 +1,16 @@
+[Unit]
+DefaultDependencies=no
+After=network.target
+
+[Service]
+Type=simple
+EnvironmentFile=/home/isaric/.config/onvif-cam-poll/%i.env
+Restart=always
+RestartSec=3
+User=isaric
+Group=isaric
+ExecStart=/bin/bash /home/isaric/.config/onvif-cam-poll/time.sh
+TimeoutStartSec=0
+
+[Install]
+WantedBy=default.target