Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NUnit assertions to the constraint model in preparation of the NUnit 4 upgrade #729

Merged
merged 13 commits into from
Aug 22, 2024

Conversation

cquirosj
Copy link
Contributor

@cquirosj cquirosj commented Aug 22, 2024

This PR contains all changes related to assertion model according to the constraint assertion model.

Using a script, we apply all assertion rules provided by the NUnit.Analyzers package. In addition, some manual interventions are done when applicable.

Plan of action

  • ⚠️ Build the solution and resolve any remaining errors or warnings
  • ✅ Review the assertions commit by commit
  • 👀 Invite another pair of eyes to re-review
  • 🏗 Set the PR to In progress on the board

@cquirosj cquirosj self-assigned this Aug 22, 2024
@cquirosj cquirosj enabled auto-merge (squash) August 22, 2024 04:22
@cquirosj cquirosj force-pushed the nunit-assertions-migration branch 2 times, most recently from b42b5e5 to 28a443e Compare August 22, 2024 04:49
@cquirosj cquirosj merged commit 7756410 into master Aug 22, 2024
2 checks passed
@cquirosj cquirosj deleted the nunit-assertions-migration branch August 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants