Remove monitoring UDP hub_port from example/test configs #3710
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This port will be chosen dynamically, and that is fine in test situations. Ongoing work to refactor monitoring radios will remove this hub_port parameter, making it either unnecessary (when non-UDP monitoring radios are used) or specified as part of the radio selection. This PR removes hub_port from tests and examples as preparation for that change.
khk-globus
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This port will be chosen dynamically, and that is fine in test situations.
This is probably also better in environments where users run multiple Parsl instances at once: they cannot all use the removed port 55055 and will interfere with each other.
Ongoing work to refactor monitoring radios will remove this hub_port parameter, making it either unnecessary (when non-UDP monitoring radios are used) or specified as part of the radio selection.
This PR removes hub_port from tests and examples as preparation for that change.
Changed Behaviour
The monitoring UDP port will be chosen dynamically in tests and examples.
Type of change