[Preparation for] remove channels on 7th November 2024 #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved, this is not needed
benclifford
added a commit
that referenced
this pull request
Oct 24, 2024
…s with merge conflicts Conflicts: docs/reference.rst parsl/channels/base.py parsl/channels/errors.py parsl/channels/ssh/ssh.py
…ests otherwise
benclifford
force-pushed
the
benc-remove-channels
branch
from
8bdc8cf
to
8c46bc6
Compare
Conflicts: parsl/channels/base.py parsl/channels/local/local.py parsl/providers/cluster_provider.py parsl/providers/condor/condor.py parsl/providers/grid_engine/grid_engine.py parsl/providers/lsf/lsf.py parsl/providers/pbspro/pbspro.py parsl/providers/slurm/slurm.py parsl/providers/torque/torque.py parsl/tests/test_providers/test_local_provider.py
Conflicts: docs/reference.rst parsl/channels/base.py parsl/channels/errors.py parsl/channels/local/local.py parsl/dataflow/dflow.py parsl/tests/test_channels/test_local_channel.py
Conflicts: docs/userguide/plugins.rst parsl/channels/base.py parsl/channels/local/local.py parsl/tests/test_providers/test_pbspro_template.py parsl/tests/test_providers/test_slurm_template.py
Conflicts: parsl/channels/local/local.py parsl/dataflow/dflow.py
This has been a basically dead code path since removal of non-remote channels: Either a user chooses to not move files (overriding move_files to False) and the push_file was not used. Or the default push_file was used, but: * this is always LocalChannel now (PR #3677) * the script directory is always the local script directory (PR #3688) and so the local channel code always skips making a copy This commit simplies all of that away into using the script path directly with putting it through the above complicated no-op.
Conflicts: parsl/providers/slurm/slurm.py
Conflicts: parsl/channels/base.py parsl/channels/local/local.py parsl/providers/local/local.py
Conflicts: parsl/channels/base.py parsl/channels/local/local.py parsl/providers/local/local.py
Conflicts: parsl/channels/base.py parsl/channels/local/local.py parsl/tests/test_channels/test_large_output.py parsl/tests/test_channels/test_local_channel.py parsl/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for implementing #3515 on 7th November 2024
This PR is some preparation for flushing out issues - accompanied by many companion PRs which do not need to wait until 7th November.
Changed Behaviour
Channel configurations, even configurations to the default LocalChannel, will break.
Inherited unix environments (from parent process) are inherited differently: execution will now use the environment at time of execution, rather than time of LocalChannel initialization.
Type of change