Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test kubernetes in CI #3482

Draft
wants to merge 76 commits into
base: master
Choose a base branch
from
Draft

Test kubernetes in CI #3482

wants to merge 76 commits into from

Conversation

benclifford
Copy link
Collaborator

@benclifford benclifford commented Jun 10, 2024

This PR is a codification of what I had to do to get pytest passing for myself while trying to review other kubernetes PRs.

The bulk of the modified files are additional test markings to label which tests require a shared filesystem (between all workers and the submit side) to store working files; and which tests require file staging (as the default file staging configuration is not valid for kubernetes, due to lack of shared file system).

There is also a bugfix for default pod names being generated as invalid format (which can fixed by users by specifying an explicit prefix)

This PR can probably be merged into master in a few stages.

@benclifford
Copy link
Collaborator Author

this is failing repeatedly on this test: (at 5c55fe6)

parsl/tests/test_regression/test_226.py F
=================================== FAILURES ===================================
__________________________________ test_no_eq __________________________________
    def test_no_eq():
>       res = get_foo_x('foo').result()

(most recently with a ManagerLost... before that, I wasn't capturing enough logging to see the whole exception.

@benclifford benclifford requested a review from rjmello June 10, 2024 15:46
@benclifford benclifford changed the title [not for merge] trying out kubernetes in github actions Test kubernetes in CI Jun 10, 2024
…read_namespaced_pod(), which is functionally the same but requires fewer permissions.
rjmello and others added 7 commits October 21, 2024 00:38
These convert any string to a valid RFC 1123 DNS subdomain or label.
- Modified Kubernetes pod names and labels to conform to RFC 1123 for
DNS subdomain names and labels, ensuring compliance with Kubernetes
naming conventions.

- Replaced the trailing timestamp in the job name with an eight-character
hex string (job ID) to improve collision avoidance.

- Replaced `app` pod label with `parsl-job-id`.

- Updated container name to use job ID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants