Made paramiko and globus optional dependencies to fix #2218 #3473
+56
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. These changes mostly look ok. Can you check off which of the following you have tested still works:
then we can figure out what else needs testing. |
|
ssh non-interactive and interactive have been tested |
|
if you aren't in a position to test globus changes, you might submit the ssh/paramiko-only changes as a separate PR. That would fit well with issue #3515 which is making SSH related stuff much more optional in preparation for removal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed paramiko and globus_sdk from requirements.txt and added them as optional modules in setup.py. Added OptionalModuleMissing errors for the affected files if usage is attempted without the correct module being installed. Removed test that required globus_sdk to test external exceptions.
Changed Behaviour
If users have code that depends on these now optional modules they might have to ensure that the proper extra modules are installed as well.
Fixes
Fixes #2218
Type of change