Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules/vpc): Add log_config block support for subnetworks #46

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

horiagunica
Copy link
Contributor

Description

Added log config support for subnetworks within vpc module.
This PR closes #45 .

Motivation and Context

Lack of log_config support for subnetworks.

How Has This Been Tested?

Customer environment + SCA.

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@horiagunica horiagunica requested a review from a team as a code owner October 2, 2024 16:41
@horiagunica
Copy link
Contributor Author

horiagunica commented Oct 2, 2024

/idempotence paths="examples/multi_nic_common examples/panorama_standalone examples/standalone_vmseries_with_metadata_bootstrap examples/vmseries_ha examples/vpc_peering_common examples/vpc_peering_common_with_autoscale examples/vpc_peering_common_with_network_tags examples/vpc_peering_dedicated examples/vpc_peering_dedicated_with_autoscale" tf_version="1.7 1.8"

Testing job ID: 11148013444
Job result: SUCCESS

@pavelrn pavelrn added the enhancement New feature or request label Oct 3, 2024
Copy link
Contributor

@pavelrn pavelrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@michalbil michalbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus the potential validation discussed oob

modules/vpc/main.tf Show resolved Hide resolved
horiagunica and others added 3 commits October 8, 2024 16:35
Copy link
Contributor

@lstadnik lstadnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@horiagunica horiagunica merged commit 9b1487a into main Oct 14, 2024
44 checks passed
@horiagunica horiagunica deleted the vpc_subnet_flow_logs branch October 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add log_config capability to subnetworks
4 participants