-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modules/vpc): Add log_config block support for subnetworks #46
Conversation
/idempotence paths="examples/multi_nic_common examples/panorama_standalone examples/standalone_vmseries_with_metadata_bootstrap examples/vmseries_ha examples/vpc_peering_common examples/vpc_peering_common_with_autoscale examples/vpc_peering_common_with_network_tags examples/vpc_peering_dedicated examples/vpc_peering_dedicated_with_autoscale" tf_version="1.7 1.8"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plus the potential validation discussed oob
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added log config support for subnetworks within
vpc
module.This PR closes #45 .
Motivation and Context
Lack of
log_config
support for subnetworks.How Has This Been Tested?
Customer environment + SCA.
Screenshots (if appropriate)
Types of changes
Checklist