Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module/lb_external): Add IPv6 support to the module #39

Merged
merged 5 commits into from
Sep 13, 2024
Merged

feat(module/lb_external): Add IPv6 support to the module #39

merged 5 commits into from
Sep 13, 2024

Conversation

pavelrn
Copy link
Contributor

@pavelrn pavelrn commented Sep 12, 2024 •
edited
Loading

Description

  • Add ip_version parameter to select IPV4 or IPV6.
  • Add support for IPv6 google_compute_address usage and creation in the module.
  • Add support for IPv6 google_compute_forwarding_rule.

Motivation and Context

IPv6 might used for connectivity in the enterprise network. Because VM-Series is a part of the network, the deployment must support IPv6.

Closes #38.

How Has This Been Tested?

Screenshots (if appropriate)

VM-Series deployment in a Common architecture.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pavelrn pavelrn requested a review from a team as a code owner September 12, 2024 20:44
@pavelrn pavelrn linked an issue Sep 12, 2024 that may be closed by this pull request
Add IPv6 support to the lb_external module #38
Closed
@pavelrn pavelrn self-assigned this Sep 12, 2024
@pavelrn pavelrn added the enhancement New feature or request label Sep 12, 2024
lstadnik
lstadnik approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@lstadnik lstadnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstadnik lstadnik mentioned this pull request Sep 13, 2024
Closed
4 tasks
@pavelrn pavelrn linked an issue Sep 13, 2024 that may be closed by this pull request
LB module not setting balancing mode correctly. #34
Closed
@pavelrn pavelrn merged commit 39c023c into main Sep 13, 2024
32 checks passed
@pavelrn pavelrn deleted the feature/ipv6-lb-external branch September 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstadnik lstadnik lstadnik approved these changes

Assignees

@pavelrn pavelrn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IPv6 support to the lb_external module LB module not setting balancing mode correctly.
2 participants
@pavelrn @lstadnik