feat(examples): flexible bootstrap options #22
Conversation
| }) | ||
| content = templatefile( | ||
| "templates/init-cfg.tmpl", | ||
| { bootstrap_options = merge(var.vmseries_common.bootstrap_options, each.value.bootstrap_options) } |
There was a problem hiding this comment.
Should we exclude some bootstrap_options here like authcodes for example?
There was a problem hiding this comment.
Good point! However, simply excluding those will result in making licensing options not available.
To exclude sensitive data from output of plan/apply, which is definitely relevant if such logs are stored in, for example, some CI/CD system, I've updated resource to local_sensitive_file.
Storing contents in the tfstate (eg. in a bucket) is a different story - you either have it or have no panorama licensing at all. This should be covered by local or bucket-level protection (encryption, appropriate access control).
Unless you have any proposal, I will mark this one as resolved.
| @@ -56,8 +53,8 @@ module "bootstrap" { | |||
| service_account = module.iam_service_account[each.value.service_account_key].email | |||
| location = each.value.location | |||
| files = merge( | |||
| { for k, v in var.vmseries : "files/${k}/config/bootstrap.xml" => "${k}/config/bootstrap.xml" }, | |||
| { for k, v in var.vmseries : "files/${k}/config/init-cfg.txt" => "${k}/config/init-cfg.txt" }, | |||
| { for k, v in var.vmseries : "files/${k}/config/bootstrap.xml" => "${k}/config/bootstrap.xml" if can(v.bootstrap_template_map) }, | |||
There was a problem hiding this comment.
How do we handle authcodes in the example? How we do the licensing in general?
There was a problem hiding this comment.
Currently authcodes are not handled in the examples.
michalbil
force-pushed
the
examples-flexible-bootstrap-options
branch
3 times, most recently
from
4fdb0d6
to
5b93561
Compare
michalbil
force-pushed
the
examples-flexible-bootstrap-options
branch
from
5b93561
to
359dc67
Compare
Description
Modify the way bootstrap options are passed in examples, so that any required one can be added at common/instance level, as needed.
Motivation and Context
Resolves #11
How Has This Been Tested?
Run plan/apply one of examples ("multi_nic_common") example with extended bootstrap options, on both common and instance levels.
Types of changes
Checklist