Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating PC-AWS-IAM-9 policy's RQL #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tplisson
Copy link

Description

Updating PC-AWS-IAM-9 policy's RQL (AWS IAM Password policy is unsecure)

Motivation and Context

Current RQL is only covering a corner case by using logical AND’s meaning the policy only alerts if all options are not compliant. The proposed RQL uses logical OR’s to cover any deviation from the recommended values.

Also the current RQL only alerts if the minimum password length matches exactly 6. The proposed RQL alerts if the minimum password length is less than 14, in line with build policy CKV_AWS_10 “AWS IAM password policy does not have a minimum of 14 characters”

Finally to avoid false positives, I’ve added a condition to ignore the AWS default password policy (isDefaultPolicy = false) which is not compliant but present in every account.

How Has This Been Tested?

The proposed RQL has been tested in production environment with many different passwords policies.

Screenshots (if appropriate)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant