Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimpeFireOnTrend #21

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add SimpeFireOnTrend #21

wants to merge 2 commits into from

Conversation

kjuli
Copy link
Member

@kjuli kjuli commented Oct 30, 2023

This PR adds the ability to also have SimpleFireOnTrend triggers. It includes a new aggregator called ChangeWindowAggregation that calculates the average change (trend) of the latest window_size values.

Furthermore, before, most triggers assumed SimpleFireOnValue in their constructors. Now, these have been changed to simply BaseTrigger to also enable SimpleFireOnTrend.

@stiesssh
Copy link
Contributor

Proposed Implementation for #38

@klinakuf klinakuf self-requested a review March 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klinakuf klinakuf Awaiting requested review from klinakuf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjuli @stiesssh