Integration test for getHistoricalTxs() #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
force-pushed
the
wallet_histtx_test
branch
from
47dae60
to
de73521
Compare
JSKitty
reviewed
Nov 23, 2024
Duddino
pushed a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Dec 2, 2024
* test: Add integration test for historical txs * Add spacing to tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Add integration tests for the wallet method
getHistoricalTxs(). The following things are tested:HistoricalTxsare correctly updated when a new block is receivedHistoricalTxHistoricalTxsdon't change when a new block is receivedNote: this tests are NOT testing that the final Activity displayed is correct.