Add Reader class and refactor shield sync #471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Refactor shield sync by introducing a Reader class.
This allows us to split the reader logic with the actual sync logic, and makes unit testing the former easier.
It makes syncing shield possible when content-length is wrong or empty, useful in e2e testing since the content-length header is removed when doing playback.
It also makes shield sync more consistent across different browsers in terms of when to split chunks, as previously we just relied on the browser (for example on my machine firefox was using much larger chunks than chrome, making the progress bar jump more)
Testing