Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reader class and refactor shield sync #471

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Nov 19, 2024

Abstract

Refactor shield sync by introducing a Reader class.
This allows us to split the reader logic with the actual sync logic, and makes unit testing the former easier.
It makes syncing shield possible when content-length is wrong or empty, useful in e2e testing since the content-length header is removed when doing playback.
It also makes shield sync more consistent across different browsers in terms of when to split chunks, as previously we just relied on the browser (for example on my machine firefox was using much larger chunks than chrome, making the progress bar jump more)

Testing

  • Sync shield and assert that it works

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit cdfbdac
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/673c7d90f98e7500084d742d
😎 Deploy Preview https://deploy-preview-471--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@panleone panleone self-requested a review November 19, 2024 11:58
@panleone panleone added the Enhancement New feature or request label Nov 19, 2024
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK cdfbdac

@panleone panleone merged commit c95fe65 into PIVX-Labs:master Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants