Add Testing section to PR description #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
added
Documentation
BreadJS
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This change to the Pull Request template adds a mandatory Testing section (exception being: if the PR cannot be tested by users, f.e: CI, Unit Tests, Non-Code changes): in which the proposer describes in clear detail and context the methods of testing the Pull Request. Examples can be seen in #177 and #178.
This system will be hooked in to https://github.com/PIVX-Labs/Prodder, which will inform our Quality Control team automatically in Discord of Pull Requests once the "Awaiting Review" label has been added to a PR.
This is part of a full workflow upgrade to improve the agility and speed of Labs, as well as security and Dev <---> User communication.