Make activity recognize proposal fees (#437)

* Make activity recognize proposal fees

* feee -> fee

scripts/dashboard/Activity.vue

@@ -56,6 +56,11 @@ const txMap = computed(() => {
             colour: 'white',
             content: translation.activityUndelegated,
         },
+        [HistoricalTxType.PROPOSAL_FEE]: {
+            icon: 'fa-minus',
+            colour: '#f93c4c',
+            content: 'Proposal Submission Fee',
+        },
         [HistoricalTxType.UNKNOWN]: {
             icon: 'fa-question',
             colour: 'white',

scripts/historical_tx.js

@@ -44,4 +44,5 @@ export const HistoricalTxType = {
     UNDELEGATION: 3,
     RECEIVED: 4,
     SENT: 5,
+    PROPOSAL_FEE: 6,
 };

scripts/script.js

@@ -227,6 +227,18 @@ export function isP2EXC(dataBytes) {
         dataBytes[25] == OP['CHECKSIG']
     );
 }
+
+/**
+ * @param {Uint8Array} dataBytes - script as byte array
+ * @returns {boolean} true if the script is a proposal fee, false otherwise
+ */
+export function isProposalFee(dataBytes) {
+    return (
+        dataBytes.length == 34 &&
+        dataBytes[0] == OP['RETURN'] &&
+        dataBytes[1] == 32
+    );
+}
 /**
  * Get address from the corresponding public key hash
  * @param {Uint8Array} pkhBytes - public key hash

scripts/transaction.js

@@ -1,7 +1,7 @@
 import { Buffer } from 'buffer';
 import { bytesToNum, numToBytes, numToVarInt, parseWIF } from './encoding.js';
 import { hexToBytes, bytesToHex, dSHA256 } from './utils.js';
-import { OP } from './script.js';
+import { isProposalFee, OP } from './script.js';
 import { varIntToNum, deriveAddress } from './encoding.js';
 import * as nobleSecp256k1 from '@noble/secp256k1';
 import { cChainParams, SAPLING_TX_VERSION } from './chain_params.js';
@@ -170,6 +170,16 @@ export class Transaction {
         );
     }
 
+    isProposalFee() {
+        for (let out of this.vout) {
+            if (out.value === cChainParams.current.proposalFee) {
+                const dataBytes = hexToBytes(out.script);
+                if (isProposalFee(dataBytes)) return true;
+            }
+        }
+        return false;
+    }
+
     /**
      * @param {Transaction} tx - transaction we want to check
      * @returns {boolean}

scripts/wallet.js

@@ -655,6 +655,8 @@ export class Wallet {
             let type = HistoricalTxType.UNKNOWN;
             if (tx.isCoinStake()) {
                 type = HistoricalTxType.STAKE;
+            } else if (tx.isProposalFee()) {
+                type = HistoricalTxType.PROPOSAL_FEE;
             } else if (this.checkForUndelegations(tx)) {
                 type = HistoricalTxType.UNDELEGATION;
                 nAmount = getFilteredCredit(OutpointState.P2PKH) / COIN;