Solve metadatatoph5 references in ph5_validate and ph5tostationxml #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrotman-pic
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I tested this on two invalid PH5s and one valid PH5 by running ph5_validate and ph5tostationxml on each. The updated help message prints in the expected error messages on both ph5_validate and ph5tostationxml. ph5tostationxml does not produce a stationxml after the error(s), as expected. The valid PH5 test of this still has the same ph5_validate & ph5tostationxml messages and output as the current master branch.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add 'deprecated tool' as prefix for metadatatoph5 in validation.py
Relevant Issues?
closes #538
Checklist
CHANGELOG.txt.CONTRIBUTORS.txt.