Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable pforma for reading rt130 or seg2 data files #543

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

damhuonglan
Copy link
Contributor

@damhuonglan damhuonglan commented Sep 5, 2024

What does this PR do?

Give Error message when pforma read rt130 or seg2 data

Relevant Issues?

#530

Checklist

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests pass.
  • Any new or changed features have are documented.
  • Changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@damhuonglan damhuonglan self-assigned this Sep 5, 2024
Copy link
Collaborator

@hrotman-pic hrotman-pic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested adding the following data formats in pforma with this PR:

RT130 (.ZIP, .cf)
SEG2 (.dat)
Texan (.TRD)
Fairfield (.rg16)
SmartSolo (.segd)

RT130 .ZIP and SEG2 .dat give the error message. RT130 .cf gives a different error message (.cf does not work in pforma anyway). I did not test RT130 .ref because one was not easily available, but I think it is an unusual extension. If the group thinks it is needed before merge I can look for a .ref.

Texan, Fairfield, and SmartSolo data all added normally.

Thank you for making these updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants