Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove reference to metadatatoph5 from ph5_validate & ph5tostationxml Response_t check #538

Open
hrotman-pic opened this issue Aug 28, 2024 · 1 comment · May be fixed by #547

Comments

@hrotman-pic
Copy link
Collaborator

hrotman-pic commented Aug 28, 2024

One of the current ph5_validate checks will print an error that refers to metadatatoph5, such as the example:

ERROR: Response_t[0]:response_file_das_a RT125_RESP is incomplete or inconsistent with Array_t_001:sr=1000 Array_t_001:sensor_model= Array_t_001:das_model=rt125. Please check with resp_load format [das_model]_[sr]_[srm]_[gain] or metadatatoph5 format [das_model]_[sensor_model]_[sr][cha] (check doesn't include [cha]).

Can this message be modified to read (example):
ERROR: Response_t[0]:response_file_das_a RT125_RESP is incomplete or inconsistent with Array_t_001:sr=1000 Array_t_001:sensor_model= Array_t_001:das_model=rt125. Please check with resp_load format [das_model]_[sr]_[srm]_[gain].

ph5tostationxml also checks and produces a similar error message, currently an example is:
ERROR: array 001 station 10000, channel 1: Response_t[1]:response_file_das_a RT125_RESP is incomplete or inconsistent with Array_t_001:sr=100 Array_t_001:sensor_model=GS11V Array_t_001:das_model=rt125. Please check with resp_load format [das_model]_[sr]_[srm]_[gain] or metadatatoph5 format [das_model]_[sensor_model]_[sr][cha] (check doesn't include [cha]).

Can this message be modified to read (example):
ERROR: array 001 station 10000, channel 1: Response_t[1]:response_file_das_a RT125_RESP is incomplete or inconsistent with Array_t_001:sr=100 Array_t_001:sensor_model=GS11V Array_t_001:das_model=rt125. Please check with resp_load format [das_model]_[sr]_[srm]_[gain].

@hrotman-pic hrotman-pic changed the title [FEATURE] Remove reference to metadatatoph5 from ph5_validate Response_t check [FEATURE] Remove reference to metadatatoph5 from ph5_validate & ph5tostationxml Response_t check Aug 29, 2024
@damhuonglan
Copy link
Contributor

Due to lots of changes in unittest if we remove the checks for metadatoph5's response, we decides to add deprecated info along with metadatoph5. For example:
ERROR: Response_t[0]:response_file_das_a RT125_RESP is incomplete or inconsistent with Array_t_001:sr=1000 Array_t_001:sensor_model= Array_t_001:das_model=rt125. Please check with resp_load format [das_model]_[sr]_[srm]_[gain] or deprecated tool metadatatoph5 format [das_model]_[sensor_model]_[sr][cha] (check doesn't include [cha]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants