Update Composer to support Laravel 6.x, move from Phpsafari -> PhpSafari #3
Conversation
|
Sorry I did not test with Travis CI prior to submitting the PR. I see that CI is testing against PHP 7.0 and PHP 7.1. The test is failing because PHPUnit 8.x is not compatible with PHP 7.0 or 7.1. We are using PHPUnit 8.x because Laravel 6 requires PHP 7.2+ (see notes below) which means we do not need to continue supporting PHPUnit 6/7. I'll attempt to submit an update for Travis CI to test with PHP 7.2 and PHP 7.3 only. My suggestion would be to bump the versioning of your Laravel packages to align with Laravel versioning so that the existing version (0.0.7) remains available for Laravel 5.x users and a new version (e.g. 6.0.0) is available for Laravel 6.x users. Per the Laravel 5.5 Upgrade Notes:
Per the Laravel 6.0 Upgrade Notes:
|
…HP 7.0/7.1 Per my comments in PR 3 (OveD-php#3): My suggestion would be to bump the versioning of your Laravel packages to align with Laravel versioning so that the existing version (0.0.7) remains available for Laravel 5.x users and a new version (e.g. 6.0.0) is available for Laravel 6.x users.
…HP 7.0/7.1 Per my comments in this PR (OveD-php/typed-collections#3): My suggestion would be to bump the versioning of your Laravel packages to align with Laravel versioning so that the existing versions (0.0.7, 2.0.2) remain available for Laravel 5.x users and a new version (e.g. 6.0.0) is available for Laravel 6.x users.
The phpsafari/health-checks (https://github.com/OveD-php/health-checks) library depends on this library. I have updated both libraries to support Laravel 6.x and am submitting PR for both libraries.
I also updated the namespace in this library so it is consistent with phpsafari/health-checks. @vistik made a similar change to the phpsafari/health-checks library a while back. See this commit:
OveD-php/health-checks@050393e
I will also submit a PR to phpsafari/health-checks with Laravel 6.x upgrades.
Both PRs should be tagged/released at the same time (e.g. this as v2.0.3, the other as v0.0.8), since my other PR expects this library to change from "Phpsafari" to "PhpSafari"