Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support API request paths under GeoServer service #585

Merged
merged 9 commits into from
Aug 31, 2023

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Aug 30, 2023

Features / Changes

  • Add support of RESTful API endpoints (i.e.: ServiceAPI) under ServiceGeoserver using Route resources
    (fixes [Feature] Extend ServiceGeoserver to allow ServiceAPI-style permissions for /web routes #584).
    Requires the Service to be configured either with the default configuration,
    or by explicitly setting api: true. When a HTTP request is sent toward a Service typed ServiceGeoserver,
    any non-OWS request (i.e.: WFS, WMS, WPS) will default to the resolution handling of typical ServiceAPI.
    This can be used notably to access the /web and /ogc endpoints of a GeoServer instance.

Bug Fixes

  • Fix UI rendering of the Permission label list under a Service edition page when a large amount of possible
    permissions is applicable. This was notably the case of ServiceGeoserver that combines permissions of multiple
    OWS-based services, which where going out of bound of the UI page.

  • Fix UI scrollbars going over the Permission titles in the User and Group permission edition pages.

    Before UI fixes:
    image

    After UI fixes:
    image

Relates to bird-house/birdhouse-deploy#348

@fmigneault fmigneault self-assigned this Aug 30, 2023
@github-actions github-actions bot added doc Documentation improvements or building problem tests Test execution or additional use cases ui Something related to the UI operations or display labels Aug 30, 2023
@github-actions github-actions bot added the ci Something related to code tests, deployment and packaging label Aug 31, 2023
@fmigneault
Copy link
Collaborator Author

CI test-remote case expected to fail for tests/test_magpie_api.py::TestCase_MagpieAPI_AdminAuth_Remote::test_GetResourceTypes_ServiceGeoserver until bumped, since >=3.35.0 condition is not met until then.
Corresponding CI test-local validates this condition assuming "latest" code including expected 3.35.0 changes.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 80.64% and project coverage change: +0.04% 🎉

Comparison is base (45f6085) 80.77% compared to head (102af33) 80.81%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   80.77%   80.81%   +0.04%     
==========================================
  Files          73       73              
  Lines       10162    10172      +10     
  Branches     1816     1818       +2     
==========================================
+ Hits         8208     8221      +13     
+ Misses       1630     1629       -1     
+ Partials      324      322       -2     
Files Changed Coverage Δ
magpie/owsrequest.py 94.64% <ø> (ø)
magpie/xml_util.py 88.88% <ø> (ø)
magpie/ui/management/views.py 47.91% <62.50%> (+0.07%) ⬆️
magpie/services.py 81.15% <86.36%> (+0.65%) ⬆️
magpie/__meta__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault fmigneault merged commit b0f1e4f into master Aug 31, 2023
18 of 20 checks passed
@fmigneault fmigneault deleted the geoserver-combined branch August 31, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to code tests, deployment and packaging doc Documentation improvements or building problem tests Test execution or additional use cases ui Something related to the UI operations or display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Extend ServiceGeoserver to allow ServiceAPI-style permissions for /web routes
1 participant