Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sensord simulator #24

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

kedder
Copy link
Member

@kedder kedder commented May 16, 2020

Allows to run variod locally on developer's machine and generate NMEA traffic for variod. Implemented with Python and documented in README.md

@kedder kedder force-pushed the testbench branch 4 times, most recently from b1abccc to e03a29a Compare May 16, 2020 18:45
Allows to run variod locally on developer's machine and generate
NMEA traffic for variod. Implemented with Python and documented
in README.md
@kedder
Copy link
Member Author

kedder commented May 16, 2020

@linuxianer99, I think I fixed all the linter error that make sense. The rest are either conflicting (like https://app.codacy.com/gh/Openvario/variod/file/44822342475/issues/source?bid=18149062&fileBranchId=18150991#l9) or doesn't make sense to me (like docstring issues or "assert" thing).

In general, the linter is not very practical if I cannot run it locally on my machine. Takes too long to wait for each build to finish.

@linuxianer99
Copy link
Member

Codacy is just a "collection" of different linters.
So the python doc string is pep257 (https://pypi.org/project/pep257/) for example.
You can also run this on a local machine i think.

I agree, that running on a local machine is better, but all actual "free" tools are web-based ..

@kedder
Copy link
Member Author

kedder commented May 16, 2020

Yes you can install those tools but they give different output, so that is not very useful.

@linuxianer99
Copy link
Member

ok, that is strange ... should be the same ... hmmm...

@kedder
Copy link
Member Author

kedder commented May 16, 2020

I suspect codacity has some kind of implicit configuration that is not necesserily tool-default. If that configuration is not part of source code, it is not possible to match it.

@linuxianer99
Copy link
Member

@kedder : Should we try to fix the Codacy issues ? Think most of them are just format things ...

@linuxianer99
Copy link
Member

I tested a bit with the pep257.
You are right ... it is awful !!
I disabled this checks in codacy ;-)

@linuxianer99 linuxianer99 merged commit 22614e2 into Openvario:master May 18, 2020
@linuxianer99 linuxianer99 linked an issue May 18, 2020 that may be closed by this pull request
@kedder
Copy link
Member Author

kedder commented May 18, 2020

@linuxianer99, sorry, I was intended to write a detailed response after I get back from work, but in short: some of the checks are mutually exclusive. E.g. one of the check suggests I need to put 2 space indent before markdown list items, but when I do, another wants me to remove the indent. Similar thing with function docstrings. I spent bunch of time trying to satisfy all checks, but it seems to be impossible in this default configuration.

Some of the checks made sense though. It basically needs to be tweaked. Default config is not very usable.

@kedder kedder deleted the testbench branch May 18, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create automatic software tests for variod
2 participants