-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce sensord simulator #24
Conversation
b1abccc
to
e03a29a
Compare
Allows to run variod locally on developer's machine and generate NMEA traffic for variod. Implemented with Python and documented in README.md
@linuxianer99, I think I fixed all the linter error that make sense. The rest are either conflicting (like https://app.codacy.com/gh/Openvario/variod/file/44822342475/issues/source?bid=18149062&fileBranchId=18150991#l9) or doesn't make sense to me (like docstring issues or "assert" thing). In general, the linter is not very practical if I cannot run it locally on my machine. Takes too long to wait for each build to finish. |
Codacy is just a "collection" of different linters. I agree, that running on a local machine is better, but all actual "free" tools are web-based .. |
Yes you can install those tools but they give different output, so that is not very useful. |
ok, that is strange ... should be the same ... hmmm... |
I suspect codacity has some kind of implicit configuration that is not necesserily tool-default. If that configuration is not part of source code, it is not possible to match it. |
@kedder : Should we try to fix the Codacy issues ? Think most of them are just format things ... |
I tested a bit with the pep257. |
@linuxianer99, sorry, I was intended to write a detailed response after I get back from work, but in short: some of the checks are mutually exclusive. E.g. one of the check suggests I need to put 2 space indent before markdown list items, but when I do, another wants me to remove the indent. Similar thing with function docstrings. I spent bunch of time trying to satisfy all checks, but it seems to be impossible in this default configuration. Some of the checks made sense though. It basically needs to be tweaked. Default config is not very usable. |
Allows to run variod locally on developer's machine and generate NMEA traffic for
variod
. Implemented with Python and documented in README.md