chore(components): do not bundle styled components in dist #16798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes RPLC-1013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR transpiles the components library in a way that next js can use. The main change is that we don't bundle styled-components anymore and instead force dependencies to provide it so there is one single version being used throughout the entire application.
closes RPLC-1013
Test Plan and Hands on Testing
Tough to really test, but this is pretty much the same code as
components@0.1.6-alpha.9which @y3rsh confirmed works for PL.Changelog
Review requests
Let's poke around the app, PD, and LL to make sure none of our components broke. stuff seems to look fine though:
https://sandbox.designer.opentrons.com/components_exclude-styled-components-from-build
http://sandbox.labware.opentrons.com/components_exclude-styled-components-from-build/
Risk assessment
Med