Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toplo branch #3

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Update toplo branch #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7d4d43
Update toplo branch
LabordePierre Jul 18, 2024
f40b8f1
remove useless tests
Nyan11 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BaselineOfToploSerialization/BaselineOfToploSerialization.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ BaselineOfToploSerialization >> dependency: spec [
with: [
spec repository: 'github://OpenSmock/Bloc-Serialization:main/src' ].

spec baseline: 'Toplo' with: [ spec repository: 'github://pharo-graphics/Toplo:master/src' ].
spec baseline: 'Toplo' with: [ spec repository: 'github://pharo-graphics/Toplo:dev/src' ].


]
2 changes: 1 addition & 1 deletion src/Toplo-Serialization/ToCheckbox.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ToCheckbox >> stonPostReferenceResolution [
self checked: aCheckValue.
self userData removeKey: #stonChecked ].
self userData at: #stonGroup ifPresent: [ :aGroup |
aGroup add: self.
aGroup register: self.
self userData removeKey: #stonGroup ]
]

Expand Down
59 changes: 15 additions & 44 deletions src/Toplo-Serialization/ToSerializerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,17 +260,17 @@ ToSerializerTest >> testToCheckbox4 [
button1 := ToCheckbox new
id: #button1;
labelText: 'button1';
addToGroup: group;
registerInGroup: group;
yourself.
button2 := ToCheckbox new
id: #button2;
labelText: 'button2';
addToGroup: group;
registerInGroup: group;
yourself.
button3 := ToCheckbox new
id: #button3;
labelText: 'button3';
addToGroup: group;
registerInGroup: group;
yourself.
pane addChildren: {
button1.
Expand All @@ -294,13 +294,17 @@ ToSerializerTest >> testToCheckbox4 [
assert: (element childAt: 2) group
equals: (element childAt: 3) group.
self
assert: (element childAt: 1) group buttons size equals: 3.
self
assert: ((element childAt: 1) group buttons includes: (element childAt: 1)).
self
assert: ((element childAt: 1) group buttons includes: (element childAt: 2)).
self
assert: ((element childAt: 1) group buttons includes: (element childAt: 3)). ]
assert: (element childAt: 1) group registeredCheckables size
equals: 3.
self assert:
((element childAt: 1) group registeredCheckables includes:
(element childAt: 1)).
self assert:
((element childAt: 1) group registeredCheckables includes:
(element childAt: 2)).
self assert:
((element childAt: 1) group registeredCheckables includes:
(element childAt: 3)) ]
]

{ #category : #tests }
Expand Down Expand Up @@ -344,39 +348,6 @@ ToSerializerTest >> testTooltip1 [
{ #category : #tests }
ToSerializerTest >> testTooltip2 [

| origin tooltip |
tooltip := BlElement new id: #tooltip; yourself.
origin := ToElement new tooltipContent: tooltip; yourself.

self
test: origin
on: [ :element | self assert: element hasTooltip.
element newTooltipWindowEvent: nil.
self assert: element hasOpenedTooltip.
self assert: ((element currentTooltipWindow childAt: 1 ) childAt: 1) id equals: #tooltip
]
]

{ #category : #tests }
ToSerializerTest >> testTooltip3 [

| origin |
origin := ToElement new
tooltipText: 'hello tooltip';
yourself.

self test: origin on: [ :element |
self assert: element hasTooltip.
element newTooltipWindowEvent: nil.
self assert: element hasOpenedTooltip.
self
assert: ((element currentTooltipWindow childAt: 1) childAt: 1) text asString
equals: 'hello tooltip' ]
]

{ #category : #tests }
ToSerializerTest >> testTooltip4 [

| origin |
origin := ToElement new
tooltipText: 'hello tooltip';
Expand All @@ -389,7 +360,7 @@ ToSerializerTest >> testTooltip4 [
]

{ #category : #tests }
ToSerializerTest >> testTooltip5 [
ToSerializerTest >> testTooltip3 [

| origin |
origin := ToElement new
Expand Down
Loading