-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(KTP-1279): Changed linear model scaling and improved sample weighting feature. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
egordm
commented
Oct 4, 2024
- Minmax scaling doesn't weigh low peaks good enough.
- Using quantile scaling now, where everything above p95 and below p5 has a sample weight of 1.
- Using standard scaling for model features.
…onential sample weighting in linear model. Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: black <action@github.com>
…arams. Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: black <action@github.com>
clara-de-smet
approved these changes
Oct 4, 2024
…arams. Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
… weight calculation. Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Signed-off-by: black <action@github.com>
Signed-off-by: Clara De Smet <clara.de.smet@alliander.com>
Signed-off-by: Clara De Smet <157587243+clara-de-smet@users.noreply.github.com>
Signed-off-by: black <action@github.com>
Signed-off-by: Clara De Smet <clara.de.smet@alliander.com>
Signed-off-by: black <action@github.com>
Signed-off-by: black <action@github.com>
…b.com/OpenSTEF/openstef into feature/KTP-1279-linear-sample-weight
Signed-off-by: black <action@github.com>
…b.com/OpenSTEF/openstef into feature/KTP-1279-linear-sample-weight
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.