Modify warning logic in WindowsJNAAffinity.setAffinity #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenp
changed the title
tgd
reviewed
Apr 19, 2024
| @@ -89,7 +89,7 @@ public void setAffinity(final BitSet affinity) { | |||
| throw new IllegalStateException("SetThreadAffinityMask((" + pid + ") , &(" + affinity + ") ) errorNo=" + e.getErrorCode(), e); | |||
| } | |||
| BitSet affinity2 = getAffinity0(); | |||
| if (!affinity2.equals(affinity)) { | |||
| if (!affinity2.intersects(affinity)) { | |||
There was a problem hiding this comment.
Is it possible to cover this with a Windows specific unit test?
There was a problem hiding this comment.
That warning is being produced on every Windows test (except when run on a single CPU). IMO it would not yield too much value to test a single log line. Especially, when we can't reproduce a negative case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117