Skip to content

Commit

Permalink
Fix misaligned margins on collapsed panels in the inspector (#2628)
Browse files Browse the repository at this point in the history
* Fix misaligned margins on collapsed panels in the inspector

---------

Co-authored-by: Stuart Corbishley <corbish@gmail.com>
  • Loading branch information
midigofrank and stuartc authored Nov 6, 2024
1 parent c46c909 commit 96bbd8d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ and this project adheres to

### Fixed

- Fix misaligned margins on collapsed panels in the inspector
[#2571](https://github.com/OpenFn/lightning/issues/2571)
- Fix sorting directions icons in projects table in the project dashboard page
[#2631](https://github.com/OpenFn/lightning/pull/2631)
- Fixed an issue where code-completion prompts don't load properly in the
Expand Down
10 changes: 7 additions & 3 deletions assets/css/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -272,15 +272,19 @@ div[id^='tippy-'] {
}

.manual-job-panel.collapsed .close-button {
@apply min-h-20;
min-height: 4.5rem;
}

.job-editor-panel.collapsed .close-button {
@apply pb-0;
}

.job-editor-panel.collapsed[data-editor-disabled='true'] .close-button {
@apply min-h-16;
min-height: 3.75rem;
}

#output-logs.collapsed .close-button {
@apply !block mb-20;
margin-bottom: 5.5rem;
}

.collapsible-panel.collapsed .panel-collapse-icon {
Expand Down
8 changes: 4 additions & 4 deletions test/lightning_web/live/workflow_live/edit_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -2099,11 +2099,11 @@ defmodule LightningWeb.WorkflowLive.EditTest do

high_priority_view |> form("#workflow-form") |> render_submit()

assert high_priority_view
|> has_element?("#inspector-workflow-version", "latest")

retry with: linear_backoff(50, 2) |> expiry(4_000),
retry with: exponential_backoff() |> cap(1_000) |> expiry(6_000),
rescue_only: [ExUnit.AssertionError] do
assert high_priority_view
|> has_element?("#inspector-workflow-version", "latest")

refute low_priority_view
|> has_element?("#inspector-workflow-version", "latest")

Expand Down

0 comments on commit 96bbd8d

Please sign in to comment.