-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] add shared-axioms module #1645
Conversation
I think the robot annotate command should do the trick. What exactly do you want to annotate, do you want to add info about the axiom changes? this is changed in each of the classes involved isnt it? I can try to do a proposal tomorrow |
This is trickier as I thought with ROBOT, what I can do is build a solution using https://github.com/jannahastings/py-horned-owl, the only problem is that is a hassle to use the tool in windows ( I already have it set up but, I am worried about reproducibility). One has to build the binaries from source etc. So it would be nice if @jannahastings adds the binaries for windows that are built with the pipeline I implemented last year, afaik these should be working up to python 3.10 in Linux, Windows and MacOS. What do you think @stap-m? should I implement this solution or do something a little more hackier that does not use the mentioned library? |
Thanks for checking @areleu Let's discuss on monday which solution is worthwhile. |
Yes I would like to help! Please give me a reminder what specifically I need to do -- should I do a new release of py-horned-owl ? |
That would be great, I made a pull request ontology-tools/py-horned-owl#12 to update the horned-owl dependency because the old one was causing issues when building. The steps would be, once the PR is merged to first count up the release version, then wait for the binaries to be built and then upload them to pypi as part of the release. It would also be nice to have the release on GitHub. The Binaries are found in Actions > All workflows (panel on the right) > Build(for windows/MacOS)/manylinux(for linux) > latest successful job > Artifacts > wheels I know its a lot of clicking, theoretically we could set up a github job that pushes to pypi whenever the version number is raised. |
Super. I'm on it... ! |
I tried to upload py-horned-owl v. 0.2.2. -- @areleu can you check if it works for you? Thanks! |
Working wonderfully, at least on windows systems. |
See #1649 |
Summary of the discussion
See #1592.
I added a new module, which contains only intermodular axioms (currently only from
information content artifact
subclasses for testing).Type of change (CHANGELOG.md)
Added
Updated
Removed
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker item
Reviewer