-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review/modex consortium #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´m not sure if it is good practice to publish actual data (CSV files) on GitHub. IMO the current workflow suggests uploading the data to the table on the OEP (I thought the consortium tables will be empty?). Or is there any reason to include the csv files I´m not aware of? @chrwm
Files:
oed_scalar_publish.csv
open_MODEX_base_check.csv
OH just noticed that GitHub showed these files to me, but they actually don't exist in the folder ?! I'm experiencing some issues with GitHub in the previous days. @chrwm can you check if the files still exists? Otherwise, I approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this LGTM :)
Just one comment, the metadata provided using the OEMetadata version 1.4.1. As this data does not concern any of the updated metadata fields, I think this is okay as it is.
Hi @jh-RLI, thanks for the review. The csv files should not be part of the pull request, I deleted them (which is part of the PR). |
Alright, I created all tables in model_draft and attached the correct metadata (incl. |
The PR created the files in the wrong folder containing a space. |
Closes #88
Cheery-picked grouped open_MODEX sources from #73
Should have been added the this PR #87