Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/modex consortium #95

Merged
merged 9 commits into from
Mar 24, 2022
Merged

Review/modex consortium #95

merged 9 commits into from
Mar 24, 2022

Conversation

chrwm
Copy link
Member

@chrwm chrwm commented Mar 22, 2022

Closes #88

Cheery-picked grouped open_MODEX sources from #73

Should have been added the this PR #87

@chrwm chrwm added review Data and Metadata review documentation labels Mar 22, 2022
@chrwm chrwm requested review from Ludee and jh-RLI March 22, 2022 16:40
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I´m not sure if it is good practice to publish actual data (CSV files) on GitHub. IMO the current workflow suggests uploading the data to the table on the OEP (I thought the consortium tables will be empty?). Or is there any reason to include the csv files I´m not aware of? @chrwm

Files:
oed_scalar_publish.csv
open_MODEX_base_check.csv

@jh-RLI
Copy link
Contributor

jh-RLI commented Mar 23, 2022

OH just noticed that GitHub showed these files to me, but they actually don't exist in the folder ?! I'm experiencing some issues with GitHub in the previous days. @chrwm can you check if the files still exists? Otherwise, I approve this PR.

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this LGTM :)

Just one comment, the metadata provided using the OEMetadata version 1.4.1. As this data does not concern any of the updated metadata fields, I think this is okay as it is.

@chrwm
Copy link
Member Author

chrwm commented Mar 23, 2022

Hi @jh-RLI, thanks for the review. The csv files should not be part of the pull request, I deleted them (which is part of the PR).
The only thing missing in the metadata strings is the id field. I'll create the empty tables in the Schema: reference then and insert the id's into the metadata to complete the process.

@chrwm
Copy link
Member Author

chrwm commented Mar 23, 2022

Alright, I created all tables in model_draft and attached the correct metadata (incl. id). If @jh-RLI don't have more issue, I'll merge the pull request tomorrow and someone with rights can move the tables from model_draft to the reference schema.

@chrwm chrwm merged commit 49add7a into master Mar 24, 2022
@chrwm chrwm deleted the review/MODEX-consortium branch March 24, 2022 07:16
@Ludee
Copy link
Member

Ludee commented Mar 30, 2022

The PR created the files in the wrong folder containing a space.
I fixed it but added it to #71.
Tables are moved now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation review Data and Metadata review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review: MODEX consortium - Data harmonisation
3 participants