Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include links in the 'to find identifiers' block #158

Open
wants to merge 2 commits into
base: live
Choose a base branch
from

Conversation

timgdavies
Copy link
Contributor

Based on #152.

@Bjwebb If this passes tests, I think it would be good to do a quick deploy of - as I hadn't spotted quite how hidden the links to lists were before.

@Bjwebb
Copy link
Member

Bjwebb commented Aug 11, 2017

@timgdavies For companies house this looks like:

To find identifiers

This list is not available online. You may need to contact the organization you plan to identify to ask if they have been given an identifier or registration number by Companies House

None

This list can also be searched on OpenCorporates.

But companies house is available online. Is it the code or the data that's incorrect? Clicking around a bit more, it looks like a problem that exists for several of the UK lists.

If it is a data problem, are you happy to merge this, and have the incorrect data reflected more visibly on the site for a bit?

@timgdavies
Copy link
Contributor Author

Ah. It is a data problem. Hmm - I think we should fix the data first on this one.

I'll see if I can get a quick fix in for those - as it would be data bug-fix.

@timgdavies
Copy link
Contributor Author

I've just looked - and this affects quite a lot of lists - so don't merge this right now - and we'll need to schedule a bit more work on the data.

@Bjwebb
Copy link
Member

Bjwebb commented Jan 23, 2018

@timgdavies Just to flag in case you didn't notice, that most recent commit conflicts with some of the changes on master.

@odscjames odscjames changed the base branch from master to live November 20, 2020 17:14
@BibianaC
Copy link
Member

@Bjwebb do you think this PR is still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants