feat: Add lang attribute to html tag #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odscjames
approved these changes
Oct 8, 2024
|
Thank you! |
michaelwood
reviewed
Oct 8, 2024
| @@ -2,7 +2,8 @@ | |||
| {% load static %} | |||
| {% load bootstrap3 %} | |||
| {% load i18n %} | |||
| <html> | |||
| {% get_current_language as LANGUAGE_CODE %} | |||
| <html lang="{{ LANGUAGE_CODE }}"> | |||
There was a problem hiding this comment.
It looks like LANGUAGE_CODE is also defined later on in this template, do we need to remove that deceleration as it's now in the outter scope to avoid any possible shadowing issue in the future?
lib-cove-web/cove/templates/base.html
Line 44 in 22e5e22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WCAG Success Criterion 3.1.1 requires that a page language is specified in a way which may be 'programmatically determined' (i.e. via the lang attribute).
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#accessibility_concerns