[PATCH v2] validation: pktio: lso: improve test coverage of custom segnum add #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
JereLeppanen
approved these changes
Nov 7, 2024
Currently the validation test of the custom segment number add operation passes even if the ODP implementation overwrites the field instead of adding to it. Fix the problem by using a non-zero value in the field in the original packet. Also select the value so that with the third segment the addition carries to the most significant byte of the two byte field used in the test. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Jere Leppänen <jere.leppanen@nokia.com>
JannePeltonen
force-pushed
the
lso-test-impr-2
branch
from
7c6fc50
to
5c6ab4d
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the validation test of the custom segment number add operation passes even if the ODP implementation overwrites the field instead of adding to it. Fix the problem by using a non-zero value in the field in the original packet. Also select the value so that with the third segment the addition carries to the most significant byte of the two byte field used in the test.