Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH v4] test: ipsecfwd: replace helper IP lookup table #1972

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[PATCH v4] test: ipsecfwd: replace helper IP lookup table #1972

merged 1 commit into from
Dec 18, 2023

Conversation

TuomasTaipale
Copy link
Collaborator

@TuomasTaipale TuomasTaipale commented Dec 13, 2023 •
edited
Loading

Replace IP lookup table provided by ODP helper library with a simpler structure.

v2:

  • Fixed potential undefined behavior with bitshifting

v3:

  • Removed sorting of forwarding entries

v4:

  • Added reviewed-by tag

@odpbuild odpbuild changed the title test: ipsecfwd: replace helper IP lookup table [PATCH v1] test: ipsecfwd: replace helper IP lookup table Dec 13, 2023
JannePeltonen
JannePeltonen requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@JannePeltonen JannePeltonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. A couple of minor comments though.

test/performance/odp_ipsecfwd.c Outdated Show resolved Hide resolved
test/performance/odp_ipsecfwd.c Outdated Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v1] test: ipsecfwd: replace helper IP lookup table [PATCH v2] test: ipsecfwd: replace helper IP lookup table Dec 14, 2023
@odpbuild odpbuild changed the title [PATCH v2] test: ipsecfwd: replace helper IP lookup table [PATCH v3] test: ipsecfwd: replace helper IP lookup table Dec 18, 2023
@TuomasTaipale
test: ipsecfwd: replace helper IP lookup table
3a1b032 
Replace IP lookup table provided by ODP helper library with a simpler
structure.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com>
@odpbuild odpbuild changed the title [PATCH v3] test: ipsecfwd: replace helper IP lookup table [PATCH v4] test: ipsecfwd: replace helper IP lookup table Dec 18, 2023
@psavol psavol merged commit 40ec75b into OpenDataPlane:master Dec 18, 2023
171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JannePeltonen JannePeltonen JannePeltonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TuomasTaipale @JannePeltonen @psavol