Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v2] github_ci: split run and build jobs into gcc and clang specific jobs #1971

Merged
merged 4 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 66 additions & 16 deletions .github/workflows/ci-pipeline-arm64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,54 @@ env:
OS: ubuntu_20.04

jobs:
Build:
Build_gcc:
if: ${{ github.repository == 'OpenDataPlane/odp' }}
runs-on: [self-hosted, ARM64]
strategy:
fail-fast: false
matrix:
cc: [gcc, clang]
conf: ['', 'CFLAGS=-O3', 'CFLAGS=-O1', 'CFLAGS=-O0 --enable-debug=full', 'CFLAGS=-Os', 'CFLAGS=-pedantic',
'--enable-lto', '--enable-lto --enable-abi-compat', '--enable-pcapng-support']
exclude:
- cc: clang
conf: '--enable-lto'
- cc: clang
conf: '--enable-lto --enable-abi-compat'
conf: ['',
'CFLAGS=-O3',
'CFLAGS=-O1',
'CFLAGS=-O0 --enable-debug=full',
'CFLAGS=-Os',
'CFLAGS=-pedantic',
'--enable-lto',
'--enable-lto --enable-abi-compat',
'--enable-pcapng-support']
steps:
- uses: OpenDataPlane/action-clean-up@main
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC="${{matrix.cc}}"
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=gcc
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH}-native /odp/scripts/ci/build_${ARCH}.sh
- if: ${{ failure() }}
uses: ./.github/actions/build-failure-log

Build_clang:
if: ${{ github.repository == 'OpenDataPlane/odp' }}
runs-on: [self-hosted, ARM64]
strategy:
fail-fast: false
matrix:
conf: ['',
'CFLAGS=-O3',
'CFLAGS=-O1',
'CFLAGS=-O0 --enable-debug=full',
'CFLAGS=-Os',
'CFLAGS=-pedantic',
'--enable-pcapng-support',
'--without-openssl --without-pcap',
'--with-crypto=armv8crypto',
'--with-crypto=ipsecmb',
'--enable-wfe-locks']
steps:
- uses: OpenDataPlane/action-clean-up@main
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=clang
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH}-native /odp/scripts/ci/build_${ARCH}.sh
- if: ${{ failure() }}
uses: ./.github/actions/build-failure-log

Build_static_u22:
if: ${{ github.repository == 'OpenDataPlane/odp' }}
runs-on: [self-hosted, ARM64]
Expand Down Expand Up @@ -130,28 +156,52 @@ jobs:
- if: ${{ failure() }}
uses: ./.github/actions/run-failure-log

Run:
Run_gcc:
if: ${{ github.repository == 'OpenDataPlane/odp' }}
runs-on: [self-hosted, ARM64]
strategy:
fail-fast: false
matrix:
cc: [gcc, clang]
conf: ['', '--enable-abi-compat', '--enable-deprecated --enable-helper-deprecated --enable-debug=full',
conf: ['',
'--enable-abi-compat',
'--enable-deprecated --enable-helper-deprecated --enable-debug=full',
'--enable-dpdk-zero-copy --disable-static-applications',
'--disable-host-optimization --enable-event-validation=warn',
'--disable-host-optimization --enable-abi-compat',
'--without-openssl --without-pcap', '--with-crypto=armv8crypto', '--with-crypto=ipsecmb']
'--without-openssl --without-pcap',
'--with-crypto=armv8crypto',
'--with-crypto=ipsecmb',
'--enable-wfe-locks']
steps:
- uses: OpenDataPlane/action-clean-up@main
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC="${{matrix.cc}}" -e ARCH="${ARCH}"
-e CXX=g++-10 -e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH}-native /odp/scripts/ci/check.sh
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=gcc -e ARCH="${ARCH}"
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH}-native /odp/scripts/ci/check.sh
- if: ${{ failure() }}
uses: ./.github/actions/run-failure-log
- if: ${{ success() }}
uses: ./.github/actions/dump-log

Run_clang:
if: ${{ github.repository == 'OpenDataPlane/odp' }}
runs-on: [self-hosted, ARM64]
strategy:
fail-fast: false
matrix:
conf: ['',
'--enable-abi-compat',
'--enable-deprecated --enable-helper-deprecated --enable-debug=full',
'--enable-dpdk-zero-copy --disable-static-applications',
'--disable-host-optimization --enable-event-validation=warn',
'--disable-host-optimization --enable-abi-compat']
steps:
- uses: OpenDataPlane/action-clean-up@main
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=clang -e ARCH="${ARCH}"
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH}-native /odp/scripts/ci/check.sh
- if: ${{ failure() }}
uses: ./.github/actions/run-failure-log

Run_CFLAGS:
if: ${{ github.repository == 'OpenDataPlane/odp' }}
runs-on: [self-hosted, ARM64]
Expand Down
72 changes: 56 additions & 16 deletions .github/workflows/ci-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,47 @@
make doxygen-doc 2>&1 | tee ./doxygen.log
! fgrep -rq warning ./doxygen.log

Build:
Build_gcc:
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
cc: [gcc, clang]
conf: ['', 'CFLAGS=-O3', 'CFLAGS=-O1', 'CFLAGS=-O0 --enable-debug=full', 'CFLAGS=-Os', 'CFLAGS=-pedantic',
'--enable-lto', '--enable-lto --enable-abi-compat', '--enable-pcapng-support']
exclude:
- cc: clang
conf: '--enable-lto'
- cc: clang
conf: '--enable-lto --enable-abi-compat'
conf: ['',
'CFLAGS=-O3',
'CFLAGS=-O1',
'CFLAGS=-O0 --enable-debug=full',
'CFLAGS=-Os',
'CFLAGS=-pedantic',
'--enable-lto',
'--enable-lto --enable-abi-compat',
'--enable-pcapng-support']
steps:
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC="${{matrix.cc}}"
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=gcc
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH} /odp/scripts/ci/build_${ARCH}.sh
- if: ${{ failure() }}
uses: ./.github/actions/build-failure-log

Build_clang:
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
conf: ['',
'CFLAGS=-O3',
'CFLAGS=-O1',
'CFLAGS=-O0 --enable-debug=full',
'CFLAGS=-Os',
'CFLAGS=-pedantic',
'--enable-pcapng-support',
'--without-openssl --without-pcap']
steps:
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=clang
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH} /odp/scripts/ci/build_${ARCH}.sh
- if: ${{ failure() }}
uses: ./.github/actions/build-failure-log

Build_static_u20:
runs-on: ubuntu-20.04
env:
Expand Down Expand Up @@ -118,9 +139,9 @@
strategy:
fail-fast: false
matrix:
cc: [gcc, clang]

Check failure on line 142 in .github/workflows/ci-pipeline.yml

View workflow job for this annotation

GitHub Actions / Checkpatch

WARNING: Do not use whitespace before Cc:

Check failure on line 142 in .github/workflows/ci-pipeline.yml

View workflow job for this annotation

GitHub Actions / Checkpatch

ERROR: Unrecognized email address: '[gcc, clang]'
conf: ['', '--enable-abi-compat', 'CFLAGS=-march=armv8.2-a', 'CFLAGS=-march=armv8-a+lse',
'--with-crypto=armv8crypto']
'--with-crypto=armv8crypto', '--enable-wfe-locks']
steps:
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC="${{matrix.cc}}"
Expand Down Expand Up @@ -279,26 +300,45 @@
- if: ${{ failure() }}
uses: ./.github/actions/run-failure-log

Run:
Run_gcc:
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
cc: [gcc, clang]
conf: ['', '--enable-abi-compat', '--enable-deprecated --enable-helper-deprecated --enable-debug=full',
conf: ['',
'--enable-abi-compat',
'--enable-deprecated --enable-helper-deprecated --enable-debug=full',
'--enable-dpdk-zero-copy --disable-static-applications',
'--disable-host-optimization --enable-event-validation=warn',
'--disable-host-optimization --enable-abi-compat',
'--without-openssl --without-pcap']
steps:
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC="${{matrix.cc}}" -e ARCH="${ARCH}"
-e CXX=g++-10 -e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH} /odp/scripts/ci/check.sh
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=gcc -e ARCH="${ARCH}"
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH} /odp/scripts/ci/check.sh
- if: ${{ failure() }}
uses: ./.github/actions/run-failure-log
- if: ${{ success() }}
uses: ./.github/actions/dump-log

Run_clang:
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
conf: ['',
'--enable-abi-compat',
'--enable-deprecated --enable-helper-deprecated --enable-debug=full',
'--enable-dpdk-zero-copy --disable-static-applications',
'--disable-host-optimization --enable-event-validation=warn',
'--disable-host-optimization --enable-abi-compat']
steps:
- uses: actions/checkout@v3
- run: sudo docker run -i -v `pwd`:/odp --privileged --shm-size 8g -e CC=clang -e ARCH="${ARCH}"
-e CONF="${{matrix.conf}}" $CONTAINER_NAMESPACE/odp-ci-${OS}-${ARCH} /odp/scripts/ci/check.sh
- if: ${{ failure() }}
uses: ./.github/actions/run-failure-log

Run_OS:
runs-on: ubuntu-20.04
strategy:
Expand Down