[PATCH v3] timer: tick does not need to start from zero #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
psavol
force-pushed
the
timer-non-zero-tick
branch
from
9f1c7c7
to
84ebace
Compare
odpbuild
changed the title
MatiasElo
approved these changes
Dec 11, 2023
test/performance/odp_timer_perf.c
Outdated
There was a problem hiding this comment.
Copyright can be updated.
There was a problem hiding this comment.
Copyright can be updated.
platform/linux-generic/odp_timer.c
Outdated
| @@ -1471,16 +1453,15 @@ void odp_timer_pool_destroy(odp_timer_pool_t tpid) | |||
|
|
|||
| uint64_t odp_timer_current_tick(odp_timer_pool_t tpid) | |||
| { | |||
| timer_pool_t *tp = timer_pool_from_hdl(tpid); | |||
| (void)tpid; | |||
There was a problem hiding this comment.
ODP_UNUSED would save one line.
There was a problem hiding this comment.
Cast to void is used with other inline functions. This function moves into inline header in the next patch.
Check that ticks and converted nanosecond value will not wrap in 10 years. Signed-off-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Measure and report timer start cycles in expire and start mode (-m 2). Signed-off-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
API does not require tick to start from zero. Optimize timer implementation by removing per timer pool start time subtraction. Signed-off-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Inline current tick function as it does not depend on timer pool structure any more. Signed-off-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
psavol
force-pushed
the
timer-non-zero-tick
branch
from
84ebace
to
5ceb9fb
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize timer current tick and other functions by using nsec time directly as the tick. API does not require tick to start from zero.