-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH v6] api/helper/linux-gen: remove deprecated items #1949
Merged
psavol
merged 7 commits into
OpenDataPlane:master
from
TuomasTaipale:dev/rem_deprecated
Dec 18, 2023
Merged
[PATCH v6] api/helper/linux-gen: remove deprecated items #1949
psavol
merged 7 commits into
OpenDataPlane:master
from
TuomasTaipale:dev/rem_deprecated
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
api/helper/linux-gen: remove deprecated items
[PATCH v1] api/helper/linux-gen: remove deprecated items
Nov 15, 2023
MatiasElo
reviewed
Nov 15, 2023
TuomasTaipale
force-pushed
the
dev/rem_deprecated
branch
from
November 16, 2023 07:32
cdf5efa
to
48331e1
Compare
odpbuild
changed the title
[PATCH v1] api/helper/linux-gen: remove deprecated items
[PATCH v2] api/helper/linux-gen: remove deprecated items
Nov 16, 2023
MatiasElo
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A period could still be added to the end of api: sched: remove deprecated items
commit message. Otherwise OK.
TuomasTaipale
force-pushed
the
dev/rem_deprecated
branch
from
November 17, 2023 12:24
48331e1
to
72d7fc7
Compare
odpbuild
changed the title
[PATCH v2] api/helper/linux-gen: remove deprecated items
[PATCH v3] api/helper/linux-gen: remove deprecated items
Nov 17, 2023
TuomasTaipale
force-pushed
the
dev/rem_deprecated
branch
from
November 22, 2023 09:06
72d7fc7
to
de6bf5c
Compare
odpbuild
changed the title
[PATCH v3] api/helper/linux-gen: remove deprecated items
[PATCH v4] api/helper/linux-gen: remove deprecated items
Nov 22, 2023
MatiasElo
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase.
MatiasElo
added
the
API Ready
API change ready to be merged (with the next API version increment)
label
Dec 12, 2023
TuomasTaipale
force-pushed
the
dev/rem_deprecated
branch
from
December 12, 2023 09:48
de6bf5c
to
17e3ea6
Compare
odpbuild
changed the title
[PATCH v4] api/helper/linux-gen: remove deprecated items
[PATCH v5] api/helper/linux-gen: remove deprecated items
Dec 12, 2023
Remove deprecated items: - `odp_cls_drop_t` type - `odp_cos_drop_set()`, `odp_cos_drop()`, `odp_cos_with_l2_priority()` and `odp_cos_with_l3_qos()` functions Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated items: - `ODP_CRYPTO_SES_CREATE_ERR_NONE`, `ODP_CRYPTO_SES_CREATE_ERR_ENOMEM`, `ODP_CRYPTO_SES_CREATE_ERR_INV_CIPHER` and `ODP_CRYPTO_SES_CREATE_ERR_INV_AUTH` session creation error constants - `odp_crypto_alg_err_t.ODP_CRYPTO_ALG_ERR_KEY_SIZE` and `odp_crypto_alg_err_t.ODP_CRYPTO_ALG_ERR_IV_INVALID` error constants - `odp_crypto_hw_err_t` type - `odp_crypto_packet_result_t.ok` field Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated `ODP_SCHED_PRIO_HIGHEST`, `ODP_SCHED_PRIO_NORMAL`, `ODP_SCHED_PRIO_LOWEST` and `ODP_SCHED_PRIO_DEFAULT` scheduling priority constants. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated items: - `ODP_CLOCK_CPU` and `ODP_CLOCK_EXT` clock source constants - `ODP_TIMER_TOOEARLY`, `ODP_TIMER_TOOLATE` and `ODP_TIMER_NOEVENT` error constants - `odp_timer_set_abs()` and `odp_timer_set_rel()` functions Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove unnecessary `<odp/api/deprecated.h>` include. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated items: - `odph_odpthread_t` and `odph_odpthread_params_t` types - `odph_thread_param_t.instance` field - `odph_odpthreads_create()` and `odph_odpthreads_join()` functions Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove unnecessary `<odp/api/deprecated.h>` include. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
TuomasTaipale
force-pushed
the
dev/rem_deprecated
branch
from
December 18, 2023 11:06
17e3ea6
to
65a46b5
Compare
odpbuild
changed the title
[PATCH v5] api/helper/linux-gen: remove deprecated items
[PATCH v6] api/helper/linux-gen: remove deprecated items
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove roughly a year old or older deprecated items.
v2:
odp_timer_set_t
typedefv3:
v4:
odp_cos_with_l2_priority()
andodp_cos_with_l3_qos()
v5: