Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v6] api/helper/linux-gen: remove deprecated items #1949

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

TuomasTaipale
Copy link
Collaborator

@TuomasTaipale TuomasTaipale commented Nov 15, 2023

Remove roughly a year old or older deprecated items.

v2:

  • Matias' comments
  • Fixed checkpatch issue
  • Re-introduced odp_timer_set_t typedef

v3:

  • Added reviewed-by tags

v4:

  • Further cleanup due to removal of odp_cos_with_l2_priority() and odp_cos_with_l3_qos()

v5:

  • Rebased

@odpbuild odpbuild changed the title api/helper/linux-gen: remove deprecated items [PATCH v1] api/helper/linux-gen: remove deprecated items Nov 15, 2023
include/odp/api/spec/classification.h Show resolved Hide resolved
helper/include/odp/helper/threads.h Show resolved Hide resolved
helper/include/odp/helper/threads.h Show resolved Hide resolved
include/odp/api/spec/timer_types.h Outdated Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v1] api/helper/linux-gen: remove deprecated items [PATCH v2] api/helper/linux-gen: remove deprecated items Nov 16, 2023
Copy link
Collaborator

@MatiasElo MatiasElo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A period could still be added to the end of api: sched: remove deprecated items commit message. Otherwise OK.

@odpbuild odpbuild changed the title [PATCH v2] api/helper/linux-gen: remove deprecated items [PATCH v3] api/helper/linux-gen: remove deprecated items Nov 17, 2023
@odpbuild odpbuild changed the title [PATCH v3] api/helper/linux-gen: remove deprecated items [PATCH v4] api/helper/linux-gen: remove deprecated items Nov 22, 2023
Copy link
Collaborator

@MatiasElo MatiasElo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.

@MatiasElo MatiasElo added the API Ready API change ready to be merged (with the next API version increment) label Dec 12, 2023
@odpbuild odpbuild changed the title [PATCH v4] api/helper/linux-gen: remove deprecated items [PATCH v5] api/helper/linux-gen: remove deprecated items Dec 12, 2023
Remove deprecated items:

  - `odp_cls_drop_t` type
  - `odp_cos_drop_set()`, `odp_cos_drop()`, `odp_cos_with_l2_priority()`
    and `odp_cos_with_l3_qos()` functions

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated items:

  - `ODP_CRYPTO_SES_CREATE_ERR_NONE`, `ODP_CRYPTO_SES_CREATE_ERR_ENOMEM`,
    `ODP_CRYPTO_SES_CREATE_ERR_INV_CIPHER` and
    `ODP_CRYPTO_SES_CREATE_ERR_INV_AUTH` session creation error constants
  - `odp_crypto_alg_err_t.ODP_CRYPTO_ALG_ERR_KEY_SIZE` and
    `odp_crypto_alg_err_t.ODP_CRYPTO_ALG_ERR_IV_INVALID` error constants
  - `odp_crypto_hw_err_t` type
  - `odp_crypto_packet_result_t.ok` field

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated `ODP_SCHED_PRIO_HIGHEST`, `ODP_SCHED_PRIO_NORMAL`,
`ODP_SCHED_PRIO_LOWEST` and `ODP_SCHED_PRIO_DEFAULT` scheduling
priority constants.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated items:

  - `ODP_CLOCK_CPU` and `ODP_CLOCK_EXT` clock source constants
  - `ODP_TIMER_TOOEARLY`, `ODP_TIMER_TOOLATE` and `ODP_TIMER_NOEVENT`
    error constants
  - `odp_timer_set_abs()` and `odp_timer_set_rel()` functions

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove unnecessary `<odp/api/deprecated.h>` include.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove deprecated items:

  - `odph_odpthread_t` and `odph_odpthread_params_t` types
  - `odph_thread_param_t.instance` field
  - `odph_odpthreads_create()` and `odph_odpthreads_join()` functions

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove unnecessary `<odp/api/deprecated.h>` include.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
@odpbuild odpbuild changed the title [PATCH v5] api/helper/linux-gen: remove deprecated items [PATCH v6] api/helper/linux-gen: remove deprecated items Dec 18, 2023
@psavol psavol merged commit 8dd73b9 into OpenDataPlane:master Dec 18, 2023
171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Ready API change ready to be merged (with the next API version increment)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants