[PATCH v4] linux-gen: timer: avoid overrun debug prints if no timers started #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
JereLeppanen
force-pushed
the
dev/fix-timer-pool-scans-missed
branch
from
332269a
to
8d212b9
Compare
odpbuild
changed the title
|
v2:
|
MatiasElo
reviewed
Nov 6, 2023
platform/linux-generic/odp_timer.c
Outdated
| @@ -828,14 +833,14 @@ static inline void timer_pool_scan_inline(int num, odp_time_t now) | |||
| continue; | |||
|
|
|||
| if (odp_atomic_cas_u64(&tp->cur_tick, &old_tick, new_tick)) { | |||
| if (tp->notify_overrun && diff > 1) { | |||
| if (odp_atomic_load_u32(&tp->notify_overrun) == 1 && diff > 1) { | |||
There was a problem hiding this comment.
ODP_DEBUG_PRINT could be added as the first condition to completely remove the potential performance hit. Same comment for timer_run_posix().
JereLeppanen
force-pushed
the
dev/fix-timer-pool-scans-missed
branch
from
8d212b9
to
5434486
Compare
odpbuild
changed the title
MatiasElo
approved these changes
Nov 6, 2023
Don't print timer pool "overrun" and "scans missed" debug prints, if no timers have been started. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
JereLeppanen
force-pushed
the
dev/fix-timer-pool-scans-missed
branch
from
5434486
to
6b72d09
Compare
odpbuild
changed the title
|
v4:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't print timer pool "overrun" and "scans missed" debug prints, if no timers have been started.