[PATCH v4] api: sched: clarify event ordering in ordered contexts #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
JannePeltonen
force-pushed
the
sched-ordering
branch
from
1b297c6
to
832ab68
Compare
odpbuild
changed the title
|
v2: order of events enqueued by single thread is the enqueue order, even across different scheduling synchronization contexts (i.e. after separate odp_schedule() calls. The previous version of the patch is available in branch sched-ordering-v1 for reference. |
psavol
reviewed
Dec 14, 2023
psavol
reviewed
Dec 14, 2023
JannePeltonen
force-pushed
the
sched-ordering
branch
from
832ab68
to
3fe0500
Compare
odpbuild
changed the title
|
v3: Added a couple of clarifications in the text and rebased. |
|
Previous version is available in sched-ordering-v2 branch. |
psavol
approved these changes
Dec 18, 2023
psavol
added
the
API Ready
|
Acked-by: Pavan Nikhilesh pbhagavatula@marvell.com |
| * on the scheduling synchronization context. The ordering rules apply | ||
| * regarless of the type (scheduled or plain) or schedule type (atomic, | ||
| * ordered, or parallel) of the destination queue. If the order type of | ||
| * the destination queue is ODP_QUEUE_ORDER_IGNORE, then the oder between |
Describe event ordering in ordered scheduling contexts more accurately. In particular, events in a destination queue are not necessarily in the same order as they are in the source queue if odp_schedule_multi() returns multiple events (sharing single scheduling synchronization context) and if the ODP application enqueues the events in a different order. Also, other enqueued events than the scheduled ones have a well defined ordering. This API change is not intended to change any functionality but just tries to document more accurately what already is the expected behaviour. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
JannePeltonen
force-pushed
the
sched-ordering
branch
from
3fe0500
to
02f3c00
Compare
odpbuild
changed the title
|
v4: Fixed the typo and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe event ordering in ordered scheduling contexts more accurately. In particular, events in a destination queue are not necessarily in the same order as they are in the source queue if odp_schedule_multi() returns multiple events (sharing single scheduling synchronization context) and if the ODP application enqueues the events in a different order. Also, other enqueued events than the scheduled ones have a well defined ordering.
This API change is not intended to change any functionality but just tries to document more accurately what already is the expected behaviour.