Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v2] validation: cls: add max pmr create test case #1915

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

psavol
Copy link
Collaborator

@psavol psavol commented Sep 22, 2023

Test how many PMRs can be added to the default CoS. There is no max number of PMR capability.

@odpbuild odpbuild changed the title validation: cls: add max pmr create test case [PATCH v1] validation: cls: add max pmr create test case Sep 22, 2023
Copy link
Collaborator

@MatiasElo MatiasElo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor print tweak.

pmr_created++;
}

printf("\n Number of CoS created: %u\n Number of PMR created %u\n", cos_created,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon missing from Number of PMR created.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in v2

Make test case names more readable by shortening the prefix.

Signed-off-by: Petri Savolainen <petri.savolainen@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Add test case that tries to create maximum number of PMRs into
the default CoS.

Signed-off-by: Petri Savolainen <petri.savolainen@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
@odpbuild odpbuild changed the title [PATCH v1] validation: cls: add max pmr create test case [PATCH v2] validation: cls: add max pmr create test case Sep 25, 2023
@psavol psavol merged commit 2b182e1 into OpenDataPlane:master Sep 25, 2023
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants