[PATCH v6] API: Crypto API additions #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
include/odp/api/spec/crypto.h
Outdated
| @@ -296,6 +296,17 @@ int odp_crypto_op(const odp_packet_t pkt_in[], | |||
| * All arrays should be of num_pkt size, except that pkt_out parameter | |||
| * is ignored when the crypto operation type is ODP_CRYPTO_OP_TYPE_BASIC. | |||
| * | |||
| * From packet ordering perspective this function behaves as if each input | |||
| * packet was enqueued to a crypto session specific ODP queue in the order | |||
| * the packets appear in the parameter array. The conceptial session input | |||
include/odp/api/spec/crypto_types.h
Outdated
| * | ||
| * This flag cannot be set when op_mode is ODP_CRYPTO_SYNC. | ||
| * | ||
| * The default value is false, |
anoobj
reviewed
Sep 26, 2023
| @@ -801,6 +815,14 @@ typedef struct odp_crypto_packet_op_param_t { | |||
| */ | |||
| int32_t dst_offset_shift; | |||
|
|
|||
| /** Use null crypto algorithms | |||
| * | |||
| * Process packet using the null cipher and null auth algorithm | |||
There was a problem hiding this comment.
Does this mean memcpy need to be done based on ranges?
There was a problem hiding this comment.
Yes, just like when you do not have the null_crypto flag set but have configured the session with null crypto.
JannePeltonen
force-pushed
the
crypto-ordering
branch
from
7ecfebb
to
350a078
Compare
odpbuild
changed the title
|
v2: fixed typos and reworded one sentence (...f.lag cannot be set... --> ...flag must be set false...). |
JannePeltonen
force-pushed
the
crypto-ordering
branch
from
350a078
to
cdbc7d0
Compare
odpbuild
changed the title
|
v3: added validation tests and implementation |
psavol
approved these changes
Oct 17, 2023
JannePeltonen
force-pushed
the
crypto-ordering
branch
from
cdbc7d0
to
8be02df
Compare
odpbuild
changed the title
|
v4: rebased |
|
ODP spec changes look good. Reviewed-by: Anoob Joseph anoobj@marvell.com |
JannePeltonen
force-pushed
the
crypto-ordering
branch
from
8be02df
to
fca5f41
Compare
odpbuild
changed the title
JannePeltonen
added
API Ready
Specify that packet order is preserved within one async crypto session but not between sessions. Specify that ordering is as if there was a session specific input queue to async crypto and then rely on generic ordering rules regarding queue enqueue without trying to specify the rules here. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Anoob Joseph <anoobj@marvell.com>
Add a crypto operation parameter that tells that a packet should be processed as if the configured algorithms were the null cipher and null auth algorithm. This makes it possible to direct packets that do not require crypto through the same crypto session as packets that require the crypto configured in the session. That in turn may be useful in preserving packet order between those packets as there are ordering guarantees in async crypto only within the same crypto session. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Anoob Joseph <anoobj@marvell.com>
Add support for the null_crypto crypto operation parameter. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Veridy that the null_crypto flag causes crypto to be skipped when null_crypto is enabled at session creation and that the flag has no effect otherwise. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Add a default case in a switch statement looking at crypto op types. This avoids a compilation failure due to -Wswitch and -Werror if a new crypto operation type is added in ODP API. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Introduce ODP_CRYPTO_OP_TYPE_BASIC_AND_OOP crypto operation type that allows both basic and out-of-place operations in the same session. The actual operation type applied depends on whether an output packet is specified. This can be useful for applications that want to perform both basic and out-of-place operations with the same crypto and cannot have two different sessions due to memory pressure or packet ordering constraints. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Anoob Joseph <anoobj@marvell.com>
Implement the BASIC_AND_OOP crypto op type which allows both basic and out-of-place operations with the same session. Add the support only for the openssl crypto module as that is now the only one which supports out-of-place crypto. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Test session created with the ODP_CRYPTO_OP_TYPE_BASIC_AND_OOP operation type with both basic and out-of-place operatons. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
MatiasElo
force-pushed
the
crypto-ordering
branch
from
fca5f41
to
c9c37d6
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api: crypto: clarify packet ordering of async crypto ops
api: crypto: add null_crypto crypto op flag for skipping crypto
api: crypto: allow both basic and out-of-place ops in one session