[PATCH v4] test: dmafwd: implement DMA poll mode #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
MatiasElo
reviewed
Sep 20, 2023
TuomasTaipale
force-pushed
the
dev/dmafwd
branch
from
cb9915d
to
4ae99a7
Compare
odpbuild
changed the title
TuomasTaipale
force-pushed
the
dev/dmafwd
branch
from
4ae99a7
to
831d19a
Compare
odpbuild
changed the title
MatiasElo
approved these changes
Sep 22, 2023
Configure cache sizes for transfer buffer and completion event pools based on the cache size command line option. These are utilized in fast path and caching may improve performance in DMA copy case. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Remove trailing periods to match existing tester logging style. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Use suitable log wording in capability checks depending on the error condition (not supported vs. failure). Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
In preparation for DMA poll mode support, add parsing skeleton for the new mode. The mode itself is not yet supported and will fail with "not yet implemented" error if chosen. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
In preparation for DMA poll mode support, restructure how transfers are initialized and sent in DMA copy case. This makes it easier to plug-in poll mode (and potentially others in the future) handling logic. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
In addition to event completion mode, DMA copy performance can now also be benchmarked with poll completion mode. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Transfer buffer and DMA completion event pools should be able to accommodate maximum inflight DMA transfer count of buffers/events. Change relevant pool creations accordingly. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Add test run for new DMA poll mode. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
TuomasTaipale
force-pushed
the
dev/dmafwd
branch
from
831d19a
to
dbfc5d6
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset implements DMA poll mode support to
odp_dmafwd.Additionally, a few improvements related to pool cache and element count configuration are introduced which may improve performance when DMA copy scenarios are used.
v2:
v3:
v4: